Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Club board added #34

Open
wants to merge 3 commits into
base: old-web
Choose a base branch
from
Open

Club board added #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ecf695
club_board_article added
MaseSharp Mar 24, 2023
f4c2b7f
club__board class added
MaseSharp Mar 24, 2023
a7da31a
Update index.html
MaseSharp Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ <h2 class="section__title">Kontakty</h2>
<a class="refs__links__link" href="https://twitter.com/klubFITpp"><i class="refs__links__link__logo ion ion-logo-twitter"></i> @klubFITpp</a>
<a class="refs__links__link" href="mailto:[email protected]"><i class="refs__links__link__logo ion ion-ios-mail"></i> [email protected]</a>
</article>
<article class="club__board">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dle BEM by toto byl element board uvnitr prvku club. Prejmenoval bych to treba jen na board nebo tak neco..

<h3>Představenstvo</h3>
<a class="refs__links__link" href="mailto:[email protected]"> Předseda Stanislav Lepič - [email protected] </a>
<a> Místopředseda Štěpán Pechman </a>
<a> Barbora Karlíková </a>
<a> Marek Severa </a>
<a> Petr Štastný </a>
</article>
Comment on lines +78 to +85
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a element je urceny pro odkazy, ne pro obycejny text. Na to je lepsi span, p nebo klidne i jen div dle toho co zrovna delas. a bez href je jen span a dela to bordel.

Jinak tohle cele bych videl radsi jako tabulku, at se to pak pekne zarovnava.

<article class="refs__links">
    <h3>Představenstvo</h3>
    <table class="refs__links__table">
        <tbody>
            <tr>
                <th>Předseda</th>
                <td>Stanislav Lepič (<a class="refs__links__table__link" href="mailto:[email protected]">[email protected]</a>)</td>
            </tr>
            <tr>
                <th>Místopředseda</th>
                <td>Štěpán Pechman</td>
            </tr>
            <tr>
                <th></th>
                <td>Barbora Karlíková</td>
            </tr>
            <tr>
                <th></th>
                <td>Marek Severa</td>
            </tr>
            <tr>
                <th></th>
                <td>Petr Štastný</td>
            </tr>
        </tbody>
    </table>
</article>

spolu s timhle CSSkem

.refs__links__table th:first-of-type {
    text-align: right;
    padding: 0 .5em 0 0;
}

.refs__links__table__link {
    color: var(--blue);
    text-decoration: none;
    font-size: 0.85em;
}

</section>
<section class="refs">
<h2 class="section__title">Další zajímavé skupiny</h2>
Expand Down
9 changes: 9 additions & 0 deletions main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,15 @@ section {
}
}

.club__board {
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
margin: 2em auto;
width: fit-content;
}

/* about */
.about {
display: flex;
Expand Down