Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Club board added #34

Open
wants to merge 3 commits into
base: old-web
Choose a base branch
from
Open

Club board added #34

wants to merge 3 commits into from

Conversation

MaseSharp
Copy link
Collaborator

@antoninkriz antoninkriz self-requested a review March 24, 2023 23:21
@@ -75,6 +75,14 @@ <h2 class="section__title">Kontakty</h2>
<a class="refs__links__link" href="https://twitter.com/klubFITpp"><i class="refs__links__link__logo ion ion-logo-twitter"></i> @klubFITpp</a>
<a class="refs__links__link" href="mailto:[email protected]"><i class="refs__links__link__logo ion ion-ios-mail"></i> [email protected]</a>
</article>
<article class="club__board">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dle BEM by toto byl element board uvnitr prvku club. Prejmenoval bych to treba jen na board nebo tak neco..

Comment on lines +78 to +85
<article class="club__board">
<h3>Představenstvo</h3>
<a class="refs__links__link" href="mailto:[email protected]"> Předseda Stanislav Lepič - [email protected] </a>
<a> Místopředseda Štěpán Pechman </a>
<a> Barbora Karlíková </a>
<a> Marek Severa </a>
<a> Petr Štastný </a>
</article>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a element je urceny pro odkazy, ne pro obycejny text. Na to je lepsi span, p nebo klidne i jen div dle toho co zrovna delas. a bez href je jen span a dela to bordel.

Jinak tohle cele bych videl radsi jako tabulku, at se to pak pekne zarovnava.

<article class="refs__links">
    <h3>Představenstvo</h3>
    <table class="refs__links__table">
        <tbody>
            <tr>
                <th>Předseda</th>
                <td>Stanislav Lepič (<a class="refs__links__table__link" href="mailto:[email protected]">[email protected]</a>)</td>
            </tr>
            <tr>
                <th>Místopředseda</th>
                <td>Štěpán Pechman</td>
            </tr>
            <tr>
                <th></th>
                <td>Barbora Karlíková</td>
            </tr>
            <tr>
                <th></th>
                <td>Marek Severa</td>
            </tr>
            <tr>
                <th></th>
                <td>Petr Štastný</td>
            </tr>
        </tbody>
    </table>
</article>

spolu s timhle CSSkem

.refs__links__table th:first-of-type {
    text-align: right;
    padding: 0 .5em 0 0;
}

.refs__links__table__link {
    color: var(--blue);
    text-decoration: none;
    font-size: 0.85em;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants