Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a donation popup to our application. #3984

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Added a donation popup to our application. #3984

merged 5 commits into from
Sep 9, 2024

Commits on Sep 9, 2024

  1. Added a donation popup to our application. 

    * The donation popup will be shown to the user every three months.
* If the user clicks the "Later" button, the popup will appear again after 3 days.
* The donation popup will only be shown when there is at least one book available in the library. If no ZIM file is present, it’s not ideal to ask for a donation, as the user has not yet used the application.
* The donation popup will only be shown for custom apps when the support_url is configured. If the support menu item is hidden in the sidebar (a feature we offer), the donation popup will not be displayed, as there is no support_url available for that custom app.
    @MohitMaliDeveloper @MohitMaliFtechiz
    MohitMaliDeveloper authored and MohitMaliFtechiz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e55deb8 View commit details
    Browse the repository at this point in the history

  2. Correctly added the bottom margin to donation popup when the bottomAp… 

    …pBar showing in the reader.
    @MohitMaliDeveloper @MohitMaliFtechiz
    MohitMaliDeveloper authored and MohitMaliFtechiz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    586bc56 View commit details
    Browse the repository at this point in the history

  3. Created a custom svg icon for showing in donation popup.

    @MohitMaliDeveloper @MohitMaliFtechiz
    MohitMaliDeveloper authored and MohitMaliFtechiz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c1de637 View commit details
    Browse the repository at this point in the history

  4. Added test cases for testing this functionality.

    @MohitMaliDeveloper @MohitMaliFtechiz
    MohitMaliDeveloper authored and MohitMaliFtechiz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8f2372b View commit details
    Browse the repository at this point in the history

  5. Improved the test cases not to show the Donation popup between tests.

    @MohitMaliDeveloper
    MohitMaliDeveloper committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    9dee134 View commit details
    Browse the repository at this point in the history