Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a donation popup to our application. #3984

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Added a donation popup to our application. #3984

merged 5 commits into from
Sep 9, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Sep 5, 2024

Fixes #3736

  • The donation popup will be shown to the user every three months.
  • If the user clicks the "Later" button, the popup will appear again after 3 days.
  • The donation popup will only be shown when there is at least one book available in the library. If no ZIM file is present, it’s not ideal to ask for a donation, as the user has not yet used the application.
  • The donation popup will only be shown for custom apps when the support_url is configured. If the support menu item is hidden in the sidebar (a feature we offer), the donation popup will not be displayed, as there is no support_url available for that custom app.
Kiwix App(When no bottomAppBar) Kiwix App(When bottomAppBar showing) Custom Apps
Screenshot from 2024-09-06 12-21-39 Screenshot from 2024-09-06 12-24-26 Screenshot from 2024-09-06 12-20-00

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft September 5, 2024 13:37
@kelson42
Copy link
Collaborator

kelson42 commented Sep 6, 2024

@Popolechien Does the approqch sounds correct to you?

@Popolechien
Copy link
Member

Yup very good

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 24.21053% with 72 lines in your changes missing coverage. Please review.

Project coverage is 57.46%. Comparing base (681e3a0) to head (9dee134).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../kiwix/kiwixmobile/core/main/CoreReaderFragment.kt 12.06% 50 Missing and 1 partial ⚠️
...ix/kiwixmobile/core/utils/DonationDialogHandler.kt 40.74% 13 Missing and 3 partials ⚠️
...wix/kiwixmobile/core/utils/SharedPreferenceUtil.kt 50.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3984      +/-   ##
============================================
- Coverage     57.76%   57.46%   -0.31%     
- Complexity     1575     1587      +12     
============================================
  Files           311      312       +1     
  Lines         12865    12960      +95     
  Branches       1641     1651      +10     
============================================
+ Hits           7432     7447      +15     
- Misses         4341     4422      +81     
+ Partials       1092     1091       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* The donation popup will be shown to the user every three months.
* If the user clicks the "Later" button, the popup will appear again after 3 days.
* The donation popup will only be shown when there is at least one book available in the library. If no ZIM file is present, it’s not ideal to ask for a donation, as the user has not yet used the application.
* The donation popup will only be shown for custom apps when the support_url is configured. If the support menu item is hidden in the sidebar (a feature we offer), the donation popup will not be displayed, as there is no support_url available for that custom app.
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review September 9, 2024 08:41
@kelson42 kelson42 merged commit f2534d3 into main Sep 9, 2024
10 of 11 checks passed
@kelson42 kelson42 deleted the Fixes#3736 branch September 9, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add donation popup
4 participants