GW170817 relative binning example script #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regarding this changes. The new styling changes pushed recently should give more explicit hints to address the ambiguity in shape of array. Reverting this in favor of the new changes
|
@ThibeauWouters Thanks for the example. It looks good to me. Regarding the bounds in the heterodyne likelihood. There is a recent merge for styling the code Line 158 in 733d802 This should give clear enough hints on the shape of array. We can also add an assert before that. Merging for now |
kazewong
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example script that is able to run PE for GW170817, addressing #38.
The hyperparameters might not be tuned ideally since these are tested and configured on the external dataset available at the TurboPE repo (i.e. here), and not tested on the data fetched online. Also, the tests were performed with TaylorF2, not IMRPhenomD. But this can serve as initial script to get started, and I have verified that it is able to run without issue.
At the same time, I have also included a small edit in likelihood.py to transpose the
boundsvariable ofmaximize_likelihood, since that confused me when working on some scripts. This simple fix might help future users in avoiding getting that confusion.