-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FirefoxHeadless is not captured in containered GitHub action with node 16 #245
Comments
Thanks for this report. Unfortunately I don't know anything about containered GitHub actions and I don't have any idea what might be going wrong based on the log. Sorry! |
…ere is a known issue with headless firefox + Karma + Node16 and running tests in a containerized GitHub/GitHub Action environment). See karma-runner/karma-firefox-launcher#245.
[APER-2063] This PR is for some cleanup after the Node 16 upgrade. The aim here is to update dependencies that will cause issues and to regenerate our `package-lock.json` file in the Credentials repo. This PR also updates the Credentials repo to use an NPM script to run our linting tests. Previously, we used `gulp` to run our linters, but `gulp` is no longer an active project (no updates since 2019) and doesn't appear to be compatible with later version of Node/NPM. We will stop running our (bok choy) acceptance tests suite as part of CI with these changes. They don't run successfully anymore after this upgrade and the bok choy framework has been deprecated for awhile now, there is nothing to gain by fixing them at this time. - regenerate the `package-lock.json` file - upgrade the `eslint-config-airbnb` and `eslint-plugin-react-hooks` dependencies - convert linting to be kicked off by NPM script, rather than using our gulpfile - update Makefile to call NPM script (intstead of Gulp) - update translation files - coverage tests in CI are failing because it can't find the firefox browser, add step to install the firefox browser - don't run (bok choy) acceptance tests as part of our CI - migrate from running our non-React JS tests with Firefox to Chromium (there is a known issue with headless firefox + Karma + Node16 and running tests in a containerized GitHub/GitHub Action environment). See karma-runner/karma-firefox-launcher#245.
We're also seeing this issue happening across multiple repositories. The error doesn't seem specific to a particular Node version running in the container, at least from my testing. I'm still investigating, but actions/runner-images#6704 could be related. Downgrading our image to |
@birtles, on my desktop PC (Ubuntu 22.04) it also does not work, so it basically does not work in Ubuntu. Playwright had similar problem: microsoft/playwright#20555 |
It works for me on Node 16 with |
Same issue in aws ec2; on Ubuntu 22.04.2 LTS. Quite interesting, but it works fine in CircleCI's |
I am using karma in combination with grunt. Running the tests work fine on my machine(node 16), docker(locally, node 16) and containered GH action(node 14), but when running in containered GH action with node 16, it fails to start Firefox. It happens both in ubuntu 18 and 20.
The version of the Firefox apt package:
105.0+build2-0ubuntu0.20.04.1
The log (src):
The text was updated successfully, but these errors were encountered: