- migrate from running some of our tests with Firefox to Chromium (th…

…ere is a known issue with headless firefox + Karma + Node16 and running tests in a containerized GitHub/GitHub Action environment). See karma-runner/karma-firefox-launcher#245.
openedx · Nov 22, 2022 · b835289 · b835289
1 parent be9771f
commit b835289
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -48,10 +48,10 @@ jobs:
           node-version: ${{ matrix.node-version }}
       - name: Install Dependencies
         run: make requirements
-      - name: Install Firefox
+      - name: Install Chromium
         run: |
           sudo apt-get update
-          sudo apt-get install --no-install-recommends -y firefox xvfb chromium-browser
+          sudo apt-get install --no-install-recommends -y chromium-browser xvfb
       - name: Run Tests
         env:
           TOXENV: ${{ matrix.django-version }}
@@ -78,13 +78,13 @@ jobs:
           node-version: ${{ matrix.node-version }}
       - name: Install Dependencies
         run: make requirements
-      - name: Install Firefox
+      - name: Install Chromium
         run: |
           sudo apt-get update
-          sudo apt-get install --no-install-recommends -y firefox xvfb chromium-browser
+          sudo apt-get install --no-install-recommends -y chromium-browser xvfb
       - name: Run Tests (required for code cov)
         env:
-          TOXENV: django32
+          TOXENV: ${{ matrix.django-version }}
         run: |
           make static
           make tests

diff --git a/karma.conf.js b/karma.conf.js
@@ -40,7 +40,6 @@ module.exports = function (config) {
       'karma-chrome-launcher',
       'karma-jasmine-jquery-2',
       'karma-jasmine',
-      'karma-firefox-launcher',
       'karma-coverage',
       'karma-spec-reporter',
       'karma-webpack',

diff --git a/package.json b/package.json
@@ -23,7 +23,7 @@
     "js-cookie": "3.0.1",
     "mini-css-extract-plugin": "2.6.0",
     "prop-types": "15.8.1",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "19.2.2",
     "react": "16.14.0",
     "react-copy-to-clipboard": "5.1.0",
     "react-dom": "16.14.0",
@@ -66,7 +66,6 @@
     "karma": "6.3.20",
     "karma-chrome-launcher": "3.1.1",
     "karma-coverage": "2.2.0",
-    "karma-firefox-launcher": "2.1.2",
     "karma-jasmine": "4.0.2",
     "karma-jasmine-jquery-2": "0.1.1",
     "karma-spec-reporter": "0.0.34",