Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespace #9362

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

ruzko
Copy link
Contributor

@ruzko ruzko commented Feb 6, 2024

Proposed Changes

There were a few spots in the install.sh script with trailing whitespaces.
This PR removes those.

Types of Changes

bugfix, formatting

Verification

Open master branch and this PR in nano with highlighting of trailing spaces

Testing

Should be unnecessary

Linked Issues

This is so small, I didn't want to create an issue for it.

User-Facing Change

NONE

Further Comments

@ruzko ruzko requested a review from a team as a code owner February 6, 2024 21:06
brandond
brandond previously approved these changes Feb 6, 2024
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We do still need an issue though, for our QA processes ;)

@ruzko
Copy link
Contributor Author

ruzko commented Feb 6, 2024

Thanks :)
Made a related issue: #9363

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.98%. Comparing base (0553a1a) to head (25ed9f2).
Report is 5 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (0553a1a) and HEAD (25ed9f2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0553a1a) HEAD (25ed9f2)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9362      +/-   ##
==========================================
- Coverage   49.74%   43.98%   -5.77%     
==========================================
  Files         178      178              
  Lines       14801    14801              
==========================================
- Hits         7363     6510     -853     
- Misses       6085     7090    +1005     
+ Partials     1353     1201     -152     
Flag Coverage Δ
e2etests 36.51% <ø> (-9.45%) ⬇️
inttests 19.72% <ø> (-17.01%) ⬇️
unittests 13.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vitorsavian
vitorsavian previously approved these changes Feb 7, 2024
@dereknola dereknola dismissed stale reviews from vitorsavian and brandond via 25ed9f2 October 1, 2024 23:06
@dereknola dereknola force-pushed the remove-trailing-whitespace branch from d905bb5 to 25ed9f2 Compare October 1, 2024 23:06
@dereknola dereknola merged commit f288cce into k3s-io:master Oct 2, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants