Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing whitespaces in install.sh #9363

Closed
ruzko opened this issue Feb 6, 2024 · 1 comment
Closed

Trailing whitespaces in install.sh #9363

ruzko opened this issue Feb 6, 2024 · 1 comment

Comments

@ruzko
Copy link
Contributor

ruzko commented Feb 6, 2024

Environmental Info:
K3s Version:

v1.28.5

Node(s) CPU architecture, OS, and Version:

Linux fedora 6.6.14-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Fri Jan 26 20:12:16 UTC 2024 x86_64 GNU/Linux

Cluster Configuration:

Not applicable

Describe the bug:

There are a couple of sections with trailing whitespaces in the install.sh script
It looks bad in text editors that highlight trailing whitespace, and occupies a byte or two of unnecessary space.

Steps To Reproduce:

  • Installed K3s:
    Using oneliner from k3s.io

Expected behavior:
No trailing whitespaces in install script

Actual behavior:
Trailing whitespaces in install script

Additional context / logs:
Related PR: #9362

Copy link
Contributor

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 45 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2024
@github-project-automation github-project-automation bot moved this from Peer Review to Done Issue in K3s Development Apr 7, 2024
@dereknola dereknola reopened this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants