Integrate with CAPI e2e test framework #95
Conversation
| By(fmt.Sprintf(format, a...)) | ||
| } | ||
|
|
||
| func setupSpecNamespace(ctx context.Context, specName string, clusterProxy framework.ClusterProxy, artifactFolder string) (*corev1.Namespace, context.CancelFunc) { |
There was a problem hiding this comment.
Just curious, why CAPI don't export these e2e test helper methods? Maybe we can ask CAPI guys
| value: https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.6.2/core-components.yaml | ||
| type: url | ||
| files: | ||
| - sourcePath: "../data/shared/v1beta1/metadata.yaml" |
There was a problem hiding this comment.
Let's try point to github release file as well.
There was a problem hiding this comment.
this is not possible, have added more comment about in shared/v1beta1/metadata.yaml
There was a problem hiding this comment.
ok, that's fine. Let's update metadata and k3s-docker file regularly to catch up CAPI release.
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
Signed-off-by: nasusoba <[email protected]>
| value: https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.6.2/core-components.yaml | ||
| type: url | ||
| files: | ||
| - sourcePath: "../data/shared/v1beta1/metadata.yaml" |
There was a problem hiding this comment.
ok, that's fine. Let's update metadata and k3s-docker file regularly to catch up CAPI release.
|
LGTM |
|
@richardcase it seems that my approval doesn't unblock the pr review gate? |
I can get that sorted. |
|
@mogliang - you should be good to go now :) Let me know if you have any issues. |
As discussed in issue 25, I have init-ed work for e2e. Summary for my work:
test/e2e( I mainly followed cluster-api-provider-rke2)test/e2e/e2e_test.gocreate_test: Create a cluster with 1 controlplane and 3 workers.node_scale_test: Create a cluster with 1 worker node, scale up and down.sigs.k8s.io/cluster-api/test/framework/*totest/e2e/helpers.go, because in the original framework, it assumed the use ofKubeadmControlPlane, so I just copied code and changed toKThreesControlplane.config/manager/kustomization.yamltodev. Add adocker-build-e2eMakefile target for building docker image with tagdev. This image will be used during e2e test.test/e2e/README.mdfor usageFuture work