Skip to content

Commit

Permalink
remove unnecessary flags
Browse files Browse the repository at this point in the history
Signed-off-by: nasusoba <[email protected]>
  • Loading branch information
nasusoba committed Mar 14, 2024
1 parent f9d70fa commit f3c1b56
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
3 changes: 2 additions & 1 deletion test/e2e/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ The e2e test use the [Cluster API test framework](https://pkg.go.dev/sigs.k8s.io
You could refer to the [Testing Cluster API](https://cluster-api.sigs.k8s.io/developer/testing) for more information.

## Run the e2e test
The e2e image will be built with tag `dev`. You should build the image first before running the test.
```shell
make docker-build-e2e # should be run everytime you change the controller code
make test-e2e # run all e2e tests
Expand All @@ -14,7 +15,7 @@ To run a specific e2e test, you can use the `GINKGO_FOCUS` environment variable
make GINKGO_FOCUS="Creating a cluster" test-e2e # only run the "Creating a cluster" e2e test
```
### Run the e2e test with tilt
It is quite useful to run the e2e test with [tilt](https://cluster-api.sigs.k8s.io/developer/tilt), so that you will not need to rebuild docker image with `make docker-build-e2e` everytime. Also you will not need to wait a new cluster creation and setup. If you set up your tilt cluster with name and current context points to this cluster, you could run:
It is quite useful to run the e2e test with [tilt](https://cluster-api.sigs.k8s.io/developer/tilt), so that you will not need to rebuild docker image with `make docker-build-e2e` everytime. Also you will not need to wait a new cluster creation and setup. If you have set up your tilt cluster and made the current context points to this cluster, you could run:
```shell
# running e2e for the cluster pointed by the current context
make USE_EXISTING_CLUSTER=true test-e2e
Expand Down
7 changes: 1 addition & 6 deletions test/e2e/config/k3s-docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,7 @@ providers:
variables:
KUBERNETES_VERSION: "v1.28.6"
KUBERNETES_VERSION_MANAGEMENT: "v1.28.6"
DOCKER_SERVICE_DOMAIN: "cluster.local"
IP_FAMILY: "dual"
DOCKER_SERVICE_CIDRS: "10.128.0.0/12"
DOCKER_POD_CIDRS: "192.168.0.0/16"
DOCKER_SERVICE_IPV6_CIDRS: "fd00:100:64::/108"
DOCKER_POD_IPV6_CIDRS: "fd00:100:96::/48"
IP_FAMILY: "IPv4"

intervals:
# the array is defined as [timeout, polling interval]
Expand Down

0 comments on commit f3c1b56

Please sign in to comment.