feat: expose custom labels for control plane machines #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to follow the pattern adopted by KCP as @zawachte mentions: #58 (comment) |
|
okay i took another pass at it, thanks for the feedback 👍 |
zawachte
reviewed
Oct 13, 2023
zawachte
previously approved these changes
Oct 13, 2023
|
This needs re-approval because pushing the comment commit dismissed the previous approval @zawachte |
zawachte
approved these changes
Oct 14, 2023
|
thanks for the review and merge! not sure if you noticed in the description that it includes manifest generation for the previous PR of mine, because i forgot it. think we should get a hotfix out for it. at this point i feel i'm starting to nag you about releases 😆 😬 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58
also, it looks like in my previous PR i forgot to regenerate the manifests. would you prefer me to put that in a separate PR to get it out more quickly as a hotfix?