Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubeSchedulerArgs won't work with Release v0.1.7 #66

Open
philjb opened this issue Nov 2, 2023 · 1 comment
Open

KubeSchedulerArgs won't work with Release v0.1.7 #66

philjb opened this issue Nov 2, 2023 · 1 comment

Comments

@philjb
Copy link
Contributor

philjb commented Nov 2, 2023

Issue

This is minor/niche, but I want to docuement that because pr #54 did not regenerate the CRD spec for the controlplane, one cannot use the kubeScheduleArgs field (KThreesControlPlane.spec.kthreesConfigSpec.serverConfig.kubeSchedulerArgs) in the v0.1.7 release.

Someone might pull release v0.1.7 and think they can use that field but they won't be able to.

As of writing, Nov 2, 2023, there has been a v0.1.8 release which doesn't have this issue and I'd assume folks would use that (or a future newer release) if starting from scratch.

Ask

I think the only additional effort for this problem is to add a note on the v0.1.7 release saying that feature doesn't work in that release. Otherwise, I think this issue ticket itself will hopefully be enough documentation if someone runs into this problem.

I only ran into myself as I am bisecting k3s versions trying to find something we saw internally.

References

@lukebond
Copy link
Contributor

maybe the release can be pulled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants