Add Python 3.12 to test matrix and add classifier #689
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
======================================
Coverage 63.2% 63.2%
======================================
Files 43 43
Lines 3231 3231
Branches 244 244
======================================
Hits 2039 2039
Misses 1175 1175
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
foarsitter
force-pushed
the
py312
branch
4 times, most recently
from
2387901
to
9f5f8c9
Compare
.github/workflows/ci.yml
Outdated
| @@ -90,7 +95,7 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| python -m pip install --upgrade "tox<4" tox-gh-actions | |||
| python -m pip install --upgrade "tox<4" tox-gh-actions setuptools | |||
There was a problem hiding this comment.
setuptools is no longer bundled with Python 3.12
|
Seems like we need to update pytest to > 7.0 in order to get the tests working for Python 3.12. My initial statement was a little to harsh. |
|
I am afraid it is a bit early to work add python3.12, it might fail until redis/redis-py#2979 In the meantime #697 will add support for pytest>=7 |
|
@WisdomPill We have an issue with async SSL in 3.12. But this should release in the 5.x final. |
|
thanks for the heads up @chayim! 😉 |
|
We need to wait for the 5.1 release of redis-py before this can be merged, right? |
|
anyway, LGTM! And thank you very much for your contribution |
|
@WisdomPill thanks for your patience :) Feel free to push to this branch! |
Everything seems fine for Python 3.12 and no change are required.