Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skin pickit keyword #49

Merged
merged 5 commits into from
Nov 3, 2019
Merged

Conversation

ryancrunchi
Copy link
Collaborator

This is a copy/pasted PR from kolton repo : kolton/d2bot-with-kolbot#1421

Added new property keyword Skin for pickit to filter rings, amulets, jewels and charms skin.
Refactored getting the skin value of item with property skinCode in Unit prototype.

Possible skin values are based on these :
image
image

  • Rings :

    • coral or chain
    • smallblue or sloop
    • bigblue or bband
    • orangestone or orangering
    • crown or eturn
  • Amulets :

    • dot or cross
    • sun
    • penta or star
  • Jewels :

    • pink
    • blue
    • orange or peach
    • green
    • red
    • white
  • Small charms :

    • brown or football
    • bear or bearfoot or bearclaw
    • m or coin
  • Large charms :

    • paw or paper
    • horn
    • tower or obelisk
  • Grand charms :

    • eye
    • dna or lace or spaghetti
    • dragon or monster
  • Usage :
    You can specify the skin without item to be identified. This means that the skin property goes the same way as type, name or quality.
    In your pickit :

// keep any unique rings unid with coral skin
[type] == ring && [quality] == unique && [skin] == coral
// or even shorter, as the skin is related to the item type. Only rings can have coral skin.
[quality] == unique && [skin] == coral

// keep any mara with dot skin
[type] == amulet && [quality] == unique && [skin] == dot # [strength] == 5 && [ColdResist] >= 20

// keep perf light rbf white
[type] == jewel && [quality] == unique && [skin] == white # [PassiveLtngMastery]+[PassiveLtngPierce] == 10
  • Caution :
    If by mistake you specify a skin that does not exist for the item type, this item will NOT be kept.
    For example
    [type] == ring && [quality] == unique && [skin] == orange # [ItemAllSkills] > 0
    It will NOT take any soj or bk because orange skin does not exist for rings.

jaenster and others added 5 commits November 1, 2019 23:21
Added `Missiles` to `sdk.unittype`.
Added Missiles Data to `GameData`.
Refactored Prototypes to use `defineProperty` instead of `__defineGetter__` and be enumerable properties.
Removed duplicate declaration of `unit` getter for `PresetUnit` class.
Added `moveBy` function to Unit prototype.
Added GeneticAlgorithmAttack bot script.
Added `missiles.txt` and `monstats.txt` sdk files from d2 mpq data.
Added `PublicJoinMaxElapsedTime` property in StarterConfig of D2BotPubJoin.
Added functions to retrieve the elapsed time of a game in the public games list in `OOG.js`.
Added new property keyword `Skin` for pickit to filter rings, amulets, jewels and charms skin.
Refactored getting the skin value of item with property `skinCode` in Unit prototype.
@jaenster
Copy link
Owner

jaenster commented Nov 3, 2019

Feels good to finally can add this for real to the bot 💙

@jaenster jaenster merged commit 0b42fba into jaenster:master Nov 3, 2019
@ryancrunchi ryancrunchi deleted the skin-pickit-property branch November 3, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants