Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add delete pet #1

Merged
merged 4 commits into from
Dec 22, 2023
Merged

feat: add delete pet #1

merged 4 commits into from
Dec 22, 2023

Conversation

Sunioatm
Copy link
Member

@Sunioatm Sunioatm commented Dec 21, 2023 •
edited
Loading

  • Remove comment
  • Change IRepository interface
  • Replace repo with repository for more clarity

bookpanda
bookpanda reviewed Dec 22, 2023
View reviewed changes
Copy link
Contributor

@bookpanda bookpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the threads. The rest looks great.

src/app/service/pet/pet.service.go Outdated Show resolved Hide resolved
src/app/service/pet/pet.service.go Outdated Show resolved Hide resolved
src/app/service/pet/pet.service.go Outdated Show resolved Hide resolved
@bookpanda
Copy link
Contributor

Also, it'd be great to add description in PRs explaining what has been changed/added/removed.

@bookpanda bookpanda merged commit fb7179c into dev Dec 22, 2023
2 checks passed
@bookpanda bookpanda deleted the feature/delete-pet branch December 22, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bookpanda bookpanda bookpanda left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sunioatm @bookpanda