-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1 from isd-sgcu/feature/delete-pet
feat: add delete pet
- Loading branch information
Showing
5 changed files
with
243 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| package pet | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
|
|
||
| "github.com/isd-sgcu/johnjud-backend/src/app/model/pet" | ||
| proto "github.com/isd-sgcu/johnjud-go-proto/johnjud/backend/pet/v1" | ||
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/grpc/status" | ||
| "gorm.io/gorm" | ||
| ) | ||
|
|
||
| type Service struct { | ||
| repository IRepository | ||
| } | ||
|
|
||
| type IRepository interface { | ||
| FindAll(result *[]*pet.Pet) error | ||
| FindOne(id string, result *[]*pet.Pet) error | ||
| Create(in *pet.Pet) error | ||
| Update(id string, result *pet.Pet) error | ||
| Delete(id string) error | ||
| } | ||
|
|
||
| func NewService(repository IRepository) *Service { | ||
| return &Service{repository: repository} | ||
| } | ||
|
|
||
| func (s *Service) Delete(ctx context.Context, req *proto.DeletePetRequest) (*proto.DeletePetResponse, error) { | ||
| err := s.repository.Delete(req.Id) | ||
| if err != nil { | ||
| if errors.Is(err, gorm.ErrRecordNotFound) { | ||
| return nil, status.Error(codes.NotFound, "pet not found") | ||
| } | ||
| return nil, status.Error(codes.Internal, "internal error") | ||
| } | ||
| return &proto.DeletePetResponse{Success: true}, nil | ||
| } | ||
|
|
||
| func (*Service) Create(context.Context, *proto.CreatePetRequest) (*proto.CreatePetResponse, error) { | ||
| panic("unimplemented") | ||
| } | ||
|
|
||
| func (*Service) FindAll(context.Context, *proto.FindAllPetRequest) (*proto.FindAllPetResponse, error) { | ||
| panic("unimplemented") | ||
| } | ||
|
|
||
| func (*Service) FindOne(context.Context, *proto.FindOnePetRequest) (*proto.FindOnePetResponse, error) { | ||
| panic("unimplemented") | ||
| } | ||
|
|
||
| func (*Service) Update(context.Context, *proto.UpdatePetRequest) (*proto.UpdatePetResponse, error) { | ||
| panic("unimplemented") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| package pet | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "math/rand" | ||
| "os/user" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/bxcodec/faker/v3" | ||
| "github.com/google/uuid" | ||
| mock "github.com/isd-sgcu/johnjud-backend/src/mocks/pet" | ||
| "gorm.io/gorm" | ||
|
|
||
| "github.com/isd-sgcu/johnjud-backend/src/app/model" | ||
| "github.com/isd-sgcu/johnjud-backend/src/app/model/pet" | ||
| proto "github.com/isd-sgcu/johnjud-go-proto/johnjud/backend/pet/v1" | ||
|
|
||
| petConst "github.com/isd-sgcu/johnjud-backend/src/constant/pet" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/suite" | ||
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/grpc/status" | ||
| ) | ||
|
|
||
| type PetServiceTest struct { | ||
| suite.Suite | ||
| Pet *pet.Pet | ||
| UpdatePet *user.User | ||
| PetDto *proto.Pet | ||
| CreatePetReqMock *proto.CreatePetRequest | ||
| UpdatePetReqMock *proto.UpdatePetRequest | ||
| } | ||
|
|
||
| func TestUserService(t *testing.T) { | ||
| suite.Run(t, new(PetServiceTest)) | ||
| } | ||
|
|
||
| func (t *PetServiceTest) SetupTest() { | ||
| t.Pet = &pet.Pet{ | ||
| Base: model.Base{ | ||
| ID: uuid.New(), | ||
| CreatedAt: time.Time{}, | ||
| UpdatedAt: time.Time{}, | ||
| DeletedAt: gorm.DeletedAt{}, | ||
| }, | ||
| Type: faker.Word(), | ||
| Species: faker.Word(), | ||
| Name: faker.Name(), | ||
| Birthdate: faker.Word(), | ||
| Gender: petConst.Gender(rand.Intn(2) + 1), | ||
| Habit: faker.Paragraph(), | ||
| Caption: faker.Paragraph(), | ||
| Status: petConst.Status(rand.Intn(2) + 1), | ||
| IsSterile: true, | ||
| IsVaccinated: true, | ||
| IsVisible: true, | ||
| IsClubPet: true, | ||
| Background: faker.Paragraph(), | ||
| Address: faker.Paragraph(), | ||
| Contact: faker.Paragraph(), | ||
| } | ||
|
|
||
| t.PetDto = &proto.Pet{ | ||
| Type: t.Pet.Type, | ||
| Species: t.Pet.Species, | ||
| Name: t.Pet.Name, | ||
| Birthdate: t.Pet.Birthdate, | ||
| Gender: proto.Gender(t.Pet.Gender), | ||
| Habit: t.Pet.Habit, | ||
| Caption: t.Pet.Caption, | ||
| Status: proto.PetStatus(t.Pet.Status), | ||
| IsSterile: t.Pet.IsSterile, | ||
| IsVaccinated: t.Pet.IsVaccinated, | ||
| IsVisible: t.Pet.IsVisible, | ||
| IsClubPet: t.Pet.IsClubPet, | ||
| Background: t.Pet.Background, | ||
| Address: t.Pet.Address, | ||
| Contact: t.Pet.Contact, | ||
| } | ||
| } | ||
| func (t *PetServiceTest) TestDeleteSuccess() { | ||
| want := &proto.DeletePetResponse{Success: true} | ||
|
|
||
| repo := new(mock.RepositoryMock) | ||
| repo.On("Delete", t.Pet.ID.String()).Return(nil) | ||
|
|
||
| srv := NewService(repo) | ||
| actual, err := srv.Delete(context.Background(), &proto.DeletePetRequest{Id: t.Pet.ID.String()}) | ||
|
|
||
| assert.Nil(t.T(), err) | ||
| assert.Equal(t.T(), want, actual) | ||
| repo.AssertExpectations(t.T()) | ||
| } | ||
|
|
||
| func (t *PetServiceTest) TestDeleteNotFound() { | ||
| repo := new(mock.RepositoryMock) | ||
| repo.On("Delete", t.Pet.ID.String()).Return(gorm.ErrRecordNotFound) | ||
|
|
||
| srv := NewService(repo) | ||
| _, err := srv.Delete(context.Background(), &proto.DeletePetRequest{Id: t.Pet.ID.String()}) | ||
|
|
||
| st, ok := status.FromError(err) | ||
| assert.True(t.T(), ok) | ||
| assert.Equal(t.T(), codes.NotFound, st.Code()) | ||
| repo.AssertExpectations(t.T()) | ||
| } | ||
|
|
||
| func (t *PetServiceTest) TestDeleteWithDatabaseError() { | ||
| repo := new(mock.RepositoryMock) | ||
| repo.On("Delete", t.Pet.ID.String()).Return(errors.New("internal server error")) | ||
|
|
||
| srv := NewService(repo) | ||
| _, err := srv.Delete(context.Background(), &proto.DeletePetRequest{Id: t.Pet.ID.String()}) | ||
|
|
||
| st, ok := status.FromError(err) | ||
| assert.True(t.T(), ok) | ||
| assert.Equal(t.T(), codes.Internal, st.Code()) | ||
| repo.AssertExpectations(t.T()) | ||
| } | ||
|
|
||
| func (t *PetServiceTest) TestDeleteWithUnexpectedError() { | ||
| repo := new(mock.RepositoryMock) | ||
| repo.On("Delete", t.Pet.ID.String()).Return(errors.New("unexpected error")) | ||
|
|
||
| srv := NewService(repo) | ||
| _, err := srv.Delete(context.Background(), &proto.DeletePetRequest{Id: t.Pet.ID.String()}) | ||
|
|
||
| assert.Error(t.T(), err) | ||
| repo.AssertExpectations(t.T()) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package pet | ||
|
|
||
| import ( | ||
| "github.com/isd-sgcu/johnjud-backend/src/app/model/pet" | ||
| "github.com/stretchr/testify/mock" | ||
| ) | ||
|
|
||
| type RepositoryMock struct { | ||
| mock.Mock | ||
| } | ||
|
|
||
| func (r *RepositoryMock) FindAll(result *[]*pet.Pet) error { | ||
| // unimplemented for now | ||
| return nil | ||
| } | ||
|
|
||
| func (r *RepositoryMock) FindOne(id string, result *[]*pet.Pet) error { | ||
| // unimplemented for now | ||
| return nil | ||
| } | ||
|
|
||
| func (r *RepositoryMock) Create(in *pet.Pet) error { | ||
| // unimplemented for now | ||
| return nil | ||
| } | ||
|
|
||
| func (r *RepositoryMock) Update(id string, result *pet.Pet) error { | ||
| // unimplemented for now | ||
| return nil | ||
| } | ||
|
|
||
| func (r *RepositoryMock) Delete(id string) error { | ||
| args := r.Called(id) | ||
| return args.Error(0) | ||
| } |