Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing del docs #60

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
Open

fixing del docs #60

wants to merge 2 commits into from

Conversation

arschles
Copy link

@arschles arschles commented Nov 2, 2015

replaces #59

cc/ @sunloverz

@arschles arschles mentioned this pull request Nov 2, 2015
@sunloverz
Copy link
Contributor

Could you resolve conflicts and I will merge?

@@ -186,8 +186,16 @@ Default is 0 seconds. Maximum is 604,800 seconds (7 days).
### Delete a Message from a Queue

```javascript
queue.del(message_id, function(error, body) {});
queue.del(message_id, {}, function(error, body) {});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to create the 'options' variable and mention that it can contain reservation_id and subscriber_name if needed (will be clearer):
var options = {};
queue.del(message_id, options, function(error, body) {});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants