-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#586] implement xml_mode for temporary parser changes #589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks real nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments are all minor improvements. Changes look real good
Created a couple new issues for some of my comments. I left the others unresolved in case there was more to do, but they look like they can be resolved to me. |
so i think we're ready to squash em, no #s. |
Yes, agreed. Consider addressing Codacy comments as well. Some unused / re-imported imports, apparently. |
Squashed . Do we want mention of |
Good point. Yes, let's document that. I think this section would be a good place to mention it, perhaps: https://github.com/irods/python-irodsclient?tab=readme-ov-file#special-characters |
README modification and additions have been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New wording looks good to me. I had one suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. I think this is ready for squashing? Are tests passing?
Tests are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, # it
@d-w-moore - # when ready. Or, please let us know of what else needs to be done for this PR. Thanks |
Done! Pound added. |
No description provided.