-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider moving irods.test.helpers.make_session
into irods.helpers
#590
Comments
FYI: I remember this #412 because waiting for an enhancement to use make_session easily where needed. |
@mstfdkmn - Good catch. Perhaps this can be closed as a duplicate of #412. Thoughts, @d-w-moore? |
Yes, this PR probably sets us on a particular path for addressing #412. As to what's the better name, |
There's already an from irods.session import make_session |
@korydraughn I'm ok with that. So then we keep #412 around for now, and consider whether it may or may not be addressed by the creation of |
Sounds good to me. |
It seems that this
irods.test.helpers.make_session
function has grown to be useful beyond just the tests. Should we move it into this module so that it can be used directly? If so, let's create an issue to look into that some other time (i.e. don't do it as part of this change). The existing version inirods.test.helpers
can then call the new one with its existing default value(s) to minimize the blast radius.Originally posted by @alanking in #589 (comment)
It may or may not be beneficial to do this, but I didn't want to lose the idea, so here's the issue. :)
The text was updated successfully, but these errors were encountered: