Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle RCL_RET_UNSUPPORTED for get_non_local_sub count from cyclonedds #137

Conversation

jfinken
Copy link

@jfinken jfinken commented Dec 11, 2023

This API is not fully implemented in cyclonedds. More information:

Here, for the get_non_local_subscription_count method

  • detect RCL_RET_UNSUPPORTED and return -1.
  • Then handle this condition in the top-level API method

For the get_non_local_subscription_count method, detect RCL_RET_UNSUPPORTED
and return -1.  Then handle this condition in the top-level method.
@jfinken
Copy link
Author

jfinken commented Dec 12, 2023

Closing this PR until a later date. The issue here:

  • a rosbag-based subscriber node (which requires serialized messages) within the same process as a publisher
  • get_non_local_subscriber_count() will (correctly) return 0, thus inter_process_publish_needed will be false.
  • However, IPC currently doesn't support serialized message delivery, thus no messages will reach the rosbag (hence needing inter_process_publish_needed to be true).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants