Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FAQ entry for changing the date format #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add FAQ entry for changing the date format #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/make.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ makedocs(
"FAQ" => Any[
"faq/another-logging-lib.md",
"faq/change-colors.md",
"faq/change-date-format.md",
"faq/config-recipes.md",
"faq/logging-to-syslog.md",
"faq/json-formatting.md",
Expand Down
9 changes: 9 additions & 0 deletions docs/src/faq/change-date-format.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# [Changing date format?](@id change_date_format)

The default date format is `yyyy-mm-dd HH:MM:SS`.
To change that, for example if you want to display milliseconds, you'll have to change the `Formatter` like so:

```julia
# Changes the formatter of the console handler of the root logger
gethandlers(getlogger())["console"].fmt = DefaultFormatter("[{date} | {name} | {level}]: {msg}"; date_fmt_string="yyyy-mm-dd HH:MM:SS.sss")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we actively want to support this approach, as it seems too easy to break. My recommendation would be to either refactor this package to support passing a dateformat kwarg to config! or explicitly mutate Memento._loggers["root"] = Logger(...) to reduce how much you're accessing private fields/components. At some point this package will require a refactor to make things less nested.

```