Add FAQ entry for changing the date format #178
Conversation
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 13 13
Lines 396 396
=======================================
Hits 389 389
Misses 7 7 Continue to review full report at Codecov.
|
|
|
||
| ```julia | ||
| # Changes the formatter of the console handler of the root logger | ||
| gethandlers(getlogger())["console"].fmt = DefaultFormatter("[{date} | {name} | {level}]: {msg}"; date_fmt_string="yyyy-mm-dd HH:MM:SS.sss") |
There was a problem hiding this comment.
I don't think we actively want to support this approach, as it seems too easy to break. My recommendation would be to either refactor this package to support passing a dateformat kwarg to config! or explicitly mutate Memento._loggers["root"] = Logger(...) to reduce how much you're accessing private fields/components. At some point this package will require a refactor to make things less nested.
I and at least one other person have needed this, I'm guessing it's common enough to have a FAQ entry.
Just not sure of the proposed solution, but this works for my case (changes the console handler for the root logger).
Should we suggest to the reader to do this for every handler they have? Unsure if/how the handlers & formatters get re-used in the logger hierarchy.