-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valid but should they be #2
Open
dericed
wants to merge
11
commits into
ietf-wg-cellar:master
Choose a base branch
from
dericed:valid_but_should_they_be
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c01a013
add reference.mkv file
dericed f9df63c
add no_DocType.mkv
dericed bfec339
add docTypeReadVersion_greaterthan_docTypeVersion.mkv
dericed 7f4837f
add EBMLReadVersion_greaterthan_EBMLVersion.mkv
dericed 064edd0
add currently_undefined_EBMLVersion.mkv
dericed d143550
add level_0_crc.mkv
dericed 843ea18
add too_many_copies_of_DocTypeVersion.mkv
dericed f0b555e
add too_many_copies_of_DocTypeVersion_and_conflicting_values.mkv
dericed cf24ed4
add invalid_EBML_ElementDataSize_in_EBMLHeader.mkv
dericed 9adf772
add really_invalid_EBML_ElementDataSize_in_EBMLHeader.mkv
dericed fd7f448
[WIP]: valid but should they be
dericed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# valid files | ||
|
||
## reference.mkv | ||
|
||
A reference file was produced via: | ||
|
||
``` | ||
ffmpeg -f lavfi -i mandelbrot=s=320x280:r=25 -f lavfi -i sine -t 0.5 -c:v ffv1 -c:a flac reference.mkv | ||
mkclean reference.mkv | ||
``` | ||
|
||
# invalid files | ||
|
||
## no_DocType.mkv | ||
|
||
The EBML Header contains no mandated DocType Element. | ||
|
||
[no_DocType.mkv](no_DocType.mkv) | ||
|
||
## docTypeReadVersion_greaterthan_docTypeVersion.mkv | ||
|
||
The docTypeReadVersion MUST be less than docTypeVersion but here it isn't. | ||
|
||
[docTypeReadVersion_greaterthan_docTypeVersion.mkv](docTypeReadVersion_greaterthan_docTypeVersion.mkv) | ||
|
||
## EBMLReadVersion_greaterthan_EBMLVersion.mkv | ||
|
||
The EBMLReadVersion MUST be less than EBMLVersion but here it isn't. | ||
|
||
[EBMLReadVersion_greaterthan_EBMLVersion.mkv](EBMLReadVersion_greaterthan_EBMLVersion.mkv) | ||
|
||
## currently_undefined_EBMLVersion.mkv | ||
|
||
The EBMLVersion is restricted to a range of defined values. At the time of this writing, only EBMLVersion=1 is defined. This value has an EBMLVersion of 255. | ||
|
||
[currently_undefined_EBMLVersion.mkv](currently_undefined_EBMLVersion.mkv) | ||
|
||
|
||
## level_0_crc.mkv | ||
|
||
The CRC-32 Element is not allowed at Level 0 but here it is included in between the EBML Header and Segment Element. | ||
[level_0_crc.mkv](level_0_crc.mkv) | ||
|
||
## too_many_copies_of_DocTypeVersion.mkv | ||
|
||
DocTypeVersion has maxOccurs=1 but here it is included twice in the EBML Header. | ||
|
||
[too_many_copies_of_DocTypeVersion.mkv](too_many_copies_of_DocTypeVersion.mkv) | ||
|
||
## too_many_copies_of_DocTypeVersion_and_conflicting_values.mkv | ||
|
||
Similar to [too_many_copies_of_DocTypeVersion.mkv](too_many_copies_of_DocTypeVersion.mkv) but here the two copies of DocTypeVersion include conflicting values, `3` and `4`. | ||
|
||
[too_many_copies_of_DocTypeVersion_and_conflicting_values.mkv](too_many_copies_of_DocTypeVersion_and_conflicting_values.mkv) | ||
|
||
## invalid_EBML_ElementDataSize_in_EBMLHeader.mkv | ||
|
||
The Elements of the EBML Header are restricted to Element Data Size values that are 4 octets in length or less. This file includes a 5 octet long Element Data Size for DocType. | ||
|
||
[invalid_EBML_ElementDataSize_in_EBMLHeader.mkv](invalid_EBML_ElementDataSize_in_EBMLHeader.mkv) | ||
|
||
## really_invalid_EBML_ElementDataSize_in_EBMLHeader.mkv | ||
|
||
Similar to [invalid_EBML_ElementDataSize_in_EBMLHeader.mkv](invalid_EBML_ElementDataSize_in_EBMLHeader.mkv) but the Element Data Size of the DocType Element is 9 octets long. | ||
[really_invalid_EBML_ElementDataSize_in_EBMLHeader.mkv](really_invalid_EBML_ElementDataSize_in_EBMLHeader.mkv) | ||
|
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added
BIN
+1.05 MB
invalid_ebml/too_many_copies_of_DocTypeVersion_and_conflicting_values.mkv
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not invalid if
EBMLReadVersion
is 1.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in EBML draft the EBMLVersion has a range of
1
reference as that is the only defined version of EBML, so EBMLVersion=2 is invalid since it goes outside of the range.