Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid but should they be #2

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

dericed
Copy link
Contributor

@dericed dericed commented Sep 18, 2016

This files are all valid to the specifications AFAICT, but perhaps they
shouldn’t be.

@robUx4
Copy link
Contributor

robUx4 commented Sep 19, 2016

Mh, github needs a visualizer for EBML files.


## currently_undefined_EBMLVersion.mkv

The EBMLVersion is restricted to a range of defined values. At the time of this writing, only EBMLVersion=1 is defined. This value has an EBMLVersion of 255.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not invalid if EBMLReadVersion is 1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in EBML draft the EBMLVersion has a range of 1 reference as that is the only defined version of EBML, so EBMLVersion=2 is invalid since it goes outside of the range.

@dericed
Copy link
Contributor Author

dericed commented Sep 20, 2016

Re visualizer for EBML. I thought of using mkvparse's mkv2xml to update an xml representation for each but many of these files would not be possible to depict in mkvparse's output.

Perhaps if the file is small enough we could have a hexadecimal text document with spacing to depict the data.

For instance

1A45DFA3 0100000000000023 #EBML
  4286 81 01 #EBMLVersion
  42F7 81 01 #EBMLReadVersion
  42F2 81 04 #EBMLMaxIDLength
  42F3 81 08 #EBMLMaxSizeLength
  4282 88 6D6174726F736B61 #DocType
  4287 81 04 #DocTypeVersion
  4285 81 02 #DocTypeReadVersion

to convert this to an EBML file, pipe the text to

grep -o '^[^#]*' | xxd -r -p > header.mkv

The grep is to strip comments. This would allow sample files as text and then we could have a Makefile to convert them to EBML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants