-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove occurences from the path #302
Conversation
I'd like to go ahead with this because it's blocking my "code generators" from the Matroska EBML Schema. IIRC the goal was originally that with just a path you can tell how to interpret the element. But that's not the case, there's not the type for example. In the end the Schema is more complete. The path is still important to describe new elements in "foreign" documents without ambiguity. |
An integer expressing the minimum permitted number of occurrences of this EBML Element within its Parent Element. The minOccurs value MUST be equal to the EBMLMinOccurrence value of the path. | ||
The minOccurs is an integer representing the minimum permitted number of occurrences of this EBML Element within its Parent Element. | ||
|
||
Each instance of the Parent Element MUST contain at least this many instances of this EBML Element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps 'contain' is the wrong word. As minOccurs=1 with a default value does not need to be 'contained' within the parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same wording that was used in EBMLMinOccurrence
, dating back to 40fe4cb.
In the next sentence(s) it actually explains in which case the element can be omitted: EBML Elements with minOccurs set to "1" that also have a default value declared are not REQUIRED to be stored
.
It was all on the same line before and still in the same paragraph.
For maxOccurs there's no such thing. How about:
Each instance of the Parent Element MUST contain at most this many instances of this EBML Element, including the unwritten mandatory element with a default value, see (#note-on-the-use-of-default-attributes-to-define-mandatory-ebml-elements).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, but this is a nice improvement.
After merging #303 this needs a rebase. |
The EBMLMasterPath is merged into the EBMLFullPath
and use more lines
and use more lines
12f0358
to
d075f69
Compare
Any further comments? I suggest merging soon. |
If the |
Ref. #292
The Matroska Schema will need to be updated when this is merged.