-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address conflict between unwritten minOccurs attribute and implementation note #292
Comments
A formatting like this with a special keyword
|
This is similar to my earlier use of "see note". I'd suggest to not include brackets within the special keyword. |
As with any keyword it must not be mistaken for a value. It could be used as a string, in which case it should be around double quotes (we should mention that in the specs if not already ?). So I guess no brackets would work too. It wouldn't be confused with a string value. |
The other way to address it would be to adjust this line:
Perhaps:
|
I think it's too specific to how we use it for now. For example an element may be mandatory (minOccurs=1) by default and implementation_note specify when it's not mandatory or when it has to be found twice. More generally I think the implementation_note should specify each value. Not sure the value should actually be set with the "regular" value in XML Schema as it can't really be mechanically interpreted. That would be misleading. |
(replying to myself) Not setting the So either we add the concept of unset value ( I think the unset option is better because it doesn't mislead the reader and programs that would parse the path to verify the validity of an element and would have no way of parsing the human-readable text |
I can't remember but is there a reason to have EBMLMinOccurrence/EBMLMaxOccurrence within the path as they are redundant to the minOccurs/maxOccurs attributes? |
I do not remember either and I don't see a reason why it's needed. It actually makes parsing the path harder and the occurence can be read from other attributes in the . So I'm OK with removing it totally. Now that I can handle XSLT, I can see how easier it is to go that way. I even had to add a check so the path values match the attributes. Removing that from the path would make an "unset" value easier to handle. The |
I agree with the idea, leave GlobalParentOccurence and remove EBMLEltOccurrence and its components, though should be careful if any documentation associated with EBMLEltOccurrence should be moved to minOccurs and maxOccurs. |
After a change in the EBML specification to clarify this, a corresponding change may be needed in the matroska specification.
See discussion on this issue at ietf-wg-cellar/matroska-specification#272 (comment)
The text was updated successfully, but these errors were encountered: