Remove autosave files when user declines to restore from them #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Hydrogen starts up, if a file has been autosaved the user will be offered the opportunity to restore from that file. If they decline it, Hydrogen should delete the autosaved file; it may be soon overwritten anyway by new autosave data. This avoids the annoying cycle I often find myself in: 1. edit file 2. quit Hydrogen discarding edits (but autosave remains) 3. open Hydrogen 4. hit "Don't Save" because I didn't want those edits 5. listen to original file without modifying (hence no autosave, but old autosave remains) 6. quit Hydrogen (silently) 7. goto 3 Also, when opening a file and restoring from its autosave, Hydrogen should count this as the song being Modified because the current content is from the autosave and is not the same as the content of the named file.
In initialising GUI elements, setting properties may set IsModified to true, even though there is no user action and the properties are only set to their existing value. Check these null actions and don't set IsModified for them. Also, remove the now-unneeded sets of IsModified to false what were needed to work around that behaviour.
|
Haha, setting autosave to
I also noted that. In #1955 I used a "No" instead of "Discard" button. But breaking the cycles sound like a very good idea. How about we offer all three options: yes, no, discard. This way the user can view both original and modified version before deciding whether to discard or apply the changes. |
Excellent idea, I like it. |
|
Oh good catch, I'll look into it. Thanks. |
cme
force-pushed
the
dev-fix-restore-discard
branch
from
88d8082
to
44dcf4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove autosave files when user declines to restore from them
When Hydrogen starts up, if a file has been autosaved the user will
be offered the opportunity to restore from that file. If they decline
it, Hydrogen should delete the autosaved file; it may be soon overwritten anyway by new autosave data.
This avoids the annoying cycle I often find myself in:
Also, when opening a file and restoring from its autosave, Hydrogen
should count this as the song being Modified because the current
content is from the autosave and is not the same as the content of
the named file.
This change also removes spurious sets of
IsModifiedin parts of the GUI, which wouldsetIsModified( true )in the GUI initialisation despite not making any actual changes, as well assetModified( false )calls that were needed to work around these spurious sets after song loading completed.