Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autosave files when user declines to restore from them #1962

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Mar 30, 2024

  1. Remove autosave files when user declines to restore from them

    When Hydrogen starts up, if a file has been autosaved the user will
    be offered the opportunity to restore from that file. If they decline
    it, Hydrogen should delete the autosaved file; it may be soon overwritten anyway by new autosave data.
    
    This avoids the annoying cycle I often find myself in:
       1. edit file
       2. quit Hydrogen discarding edits (but autosave remains)
       3. open Hydrogen
       4. hit "Don't Save" because I didn't want those edits
       5. listen to original file without modifying (hence no autosave, but old autosave remains)
       6. quit Hydrogen (silently)
       7. goto 3
    
    Also, when opening a file and restoring from its autosave, Hydrogen
    should count this as the song being Modified because the current
    content is from the autosave and is not the same as the content of
    the named file.
    cme committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    e20434c View commit details
    Browse the repository at this point in the history
  2. Remove spurious sets of isModified for GUI actions

    In initialising GUI elements, setting properties may set IsModified
    to true, even though there is no user action and the properties are
    only set to their existing value. Check these null actions and don't
    set IsModified for them. Also, remove the now-unneeded sets of
    IsModified to false what were needed to work around that behaviour.
    cme committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    d581bb2 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Configuration menu
    Copy the full SHA
    235de1d View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Configuration menu
    Copy the full SHA
    44dcf4c View commit details
    Browse the repository at this point in the history