Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix safety_manager path #411

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

delihus
Copy link
Contributor

@delihus delihus commented Sep 13, 2024

Description

Chars are not parsing correctly. For hotfix I changed it to string.

Requirements

  • Code style guidelines followed
  • Documentation updated

Tests 🧪

  • Robot
  • Container
  • Simulation

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of string data in the Safety Manager, enhancing type safety and clarity.
  • Chores
    • Refined internal string management without impacting overall functionality.

Signed-off-by: Jakub Delicat <[email protected]>
@delihus delihus requested a review from KmakD September 13, 2024 00:28
Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Walkthrough

The changes in the SafetyManagerNode constructor involve updating how the shutdown_hosts_path parameter is stored in the shutdown_initial_blackboard map. The code now uses the std::string directly instead of converting it to a C-style string. This modification enhances type safety and clarity in string handling without altering the overall functionality of the SafetyManagerNode.

Changes

File Change Summary
panther_manager/src/safety_manager_node.cpp Updated storage of shutdown_hosts_path from const char* to std::string in the constructor.

Assessment against linked issues

Objective Addressed Explanation
Improve string handling (N/A)

Possibly related issues

  • None identified.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@delihus delihus removed the request for review from KmakD September 13, 2024 00:29
@rafal-gorecki rafal-gorecki merged commit 05324f5 into ros2-devel Oct 1, 2024
1 check passed
@rafal-gorecki rafal-gorecki deleted the ros2-hotfix-safety-manager branch October 1, 2024 10:45
@coderabbitai coderabbitai bot mentioned this pull request Dec 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants