Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 update msgs #352

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Ros2 update msgs #352

merged 1 commit into from
Jun 20, 2024

Conversation

delihus
Copy link
Contributor

@delihus delihus commented Jun 20, 2024

Update MSGS

Summary by CodeRabbit

  • New Features

    • Introduced a new configuration parameter for LED control enablement in hardware settings.
    • Added new ROS service servers for various hardware controls including LED, fan, charger, and motor power.
  • Bug Fixes

    • Improved thread safety in E-Stop handling mechanisms with mutex locking.
    • Updated GPIO configurations for more reliable hardware interaction.
  • Documentation

    • Updated README files to reflect changes in ROS topics and hardware configurations related to GPS data acquisition and GPIO interactions.
  • Chores

    • Added new dependencies and reordered existing ones to improve compatibility and functionality.
    • Updated internal references and namespaces for better code organization and clarity.

Signed-off-by: Jakub Delicat <[email protected]>
@delihus delihus requested a review from KmakD June 20, 2024 12:42
Copy link
Contributor

coderabbitai bot commented Jun 20, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

This update introduces several changes across various components of the Panther project, including enhancement of configurations, dependency modifications, namespace updates, and the introduction of new hardware control functionalities. Specific changes include updating repository versions, improving build and dependency management, refining ROS interface methods, and adding new service capabilities such as LED control and hardware diagnostics.

Changes

File/Path Change Summary
.github/workflows/release-project.yaml Removed the date field from a JSON object within a job configuration.
.github/workflows/release-repository.yaml Added fetch-depth: 0 to the actions/checkout step.
panther/panther_hardware.repos Updated the version of the panther_msgs repository.
panther/panther_simulation.repos Updated the version of the panther_msgs repository.
panther_controller/launch/controller.launch.py Added a new configuration parameter for LED control enablement.
panther_gazebo/README.md Updated references and configurations related to GPS data acquisition.
panther_hardware_interfaces/CMakeLists.txt Reordered dependencies, added new dependencies, and modified source files included in the library.
panther_hardware_interfaces/CODE_STRUCTURE.md Added a section on GPIODriver and updated the description of GPIOController.
panther_hardware_interfaces/README.md Modified ROS topics and service servers related to Panther system diagnostics and hardware controls.
.../cmake/SuperBuild.cmake Added ep_libgpiod to dependencies and configured its setup.
.../include/.../gpio_controller.hpp Renamed references from panther_gpiod to panther_hardware_interfaces and added LEDControlEnable method.
.../include/.../gpio_driver.hpp Changed namespace from panther_gpiod to panther_hardware_interfaces and updated header guard.
.../include/.../panther_system_ros_interface.hpp Added qos_profile parameter to AddService and RegisterService methods.
.../package.xml Updated authors, added and reordered dependencies, and adjusted the export section.
.../src/gpio_controller.cpp Updated the namespace references and modified method signatures for consistency.
.../src/gpio_driver.cpp Renamed namespaces and updated consumer name for GPIO configurations.
.../src/panther_system.cpp Refactored error logging, added a new service for LED control, and modified QoS settings.
.../src/panther_system_e_stop.cpp Introduced mutex locking for thread safety and handled E-Stop triggers from external devices.
.../src/panther_system_ros_interface.cpp Added qos_profile parameter to service registration and refined method parameters and logic.
.../test/test_gpio_controller.cpp Reorganized GPIO pin configurations and updated test cases for new GPIO pin usage.
.../test/test_gpio_driver.cpp Updated namespace and class references related to the GPIO driver.

Sequence Diagram(s)

sequenceDiagram
    participant User as Developer
    participant GitHubActions as GitHub Actions
    participant Repo as Repository
    participant Service1 as Hardware Interface Service
    participant ROSNode1 as ROS Node
    
    User->>Repo: Push changes
    Repo->>GitHubActions: Trigger workflows
    
    GitHubActions->>GitHubActions: Execute workflows
    GitHubActions->>Repo: Checkout repository (with fetch-depth: 0)
    
    GitHubActions->>Repo: Update dependencies and configurations
    GitHubActions->>Repo: Build project
    
    User->>ROSNode1: Deploy new updates
    ROSNode1->>Service1: Register services (with modified QoS settings)
    ROSNode1->>Service1: Add new hardware control services (e.g., LED control)

    Service1-->>ROSNode1: Confirm service registration
    ROSNode1-->>User: Deployment completed
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@delihus delihus changed the base branch from ros2 to ros2-devel June 20, 2024 12:43
@KmakD KmakD merged commit e042431 into ros2-devel Jun 20, 2024
1 check failed
@KmakD KmakD deleted the ros2_update_msgs branch June 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants