Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing local_files_only in record/replay #540

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

Cadene
Copy link
Collaborator

@Cadene Cadene commented Dec 2, 2024

What this does

  • Add --local-files-only for record/replay

How it was tested + How to checkout & try?

  1. Recorded 2 episodes without pushing on the hub
python lerobot/scripts/control_robot.py record \
  --robot-path lerobot/configs/robot/so100.yaml \
  --fps 30 \
  --repo-id cadene/so100_5_lego_test \
  --num-episodes 2 \
  --warmup-time-s 5 \
  --episode-time-s 60 \
  --reset-time-s 30 \
  --single-task "Pick up the lego blocks and put them in the box on the right side of the robot." \
  --push-to-hub 0
  1. Resumed recording and record 1 more episode:
python lerobot/scripts/control_robot.py record \
  --robot-path lerobot/configs/robot/so100.yaml \
  --fps 30 \
  --repo-id cadene/so100_5_lego_test \
  --num-episodes 1 \
  --warmup-time-s 1 \
  --episode-time-s 60 \
  --reset-time-s 30 \
  --single-task "Pick up the lego blocks and put them in the box on the right side of the robot." \
  --resume 1 \
  --local-files-only 1
  1. Visualized the dataset offline.
python lerobot/scripts/visualize_dataset_html.py     \
--repo-id cadene/so100_5_lego_test     \
--local-files-only 1

@Cadene Cadene requested a review from aliberts December 2, 2024 17:00
@Cadene Cadene added the 🐛 Bug Something isn't working label Dec 2, 2024
@Cadene Cadene marked this pull request as ready for review December 2, 2024 17:00
Copy link
Collaborator

@aliberts aliberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!
Tests are failing, can you add this change in tests/test_control_robot.py::test_record_and_replay_and_policy?

- replay(robot, episode=0, fps=1, root=root, repo_id=repo_id, play_sounds=False)
+ replay(robot, episode=0, fps=1, root=root, repo_id=repo_id, play_sounds=False, local_files_only=True)

Also, end-to-end tests are failing but this is because they are downloading full datasets from the hub each time and we're capping out the github runners capacities. We should disable them until we fix this.

Copy link
Collaborator

@aliberts aliberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cadene Cadene merged commit 286bca3 into main Dec 3, 2024
6 checks passed
@Cadene Cadene deleted the user/rcadene/2024_12_02_fix_resume_record branch December 3, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants