Fix several bugs relating to saving offline datasets when not logged in to HuggingFace #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This PR fixes #534 and fixes several bugs I found that all relate to not being logged in to huggingface.
I found a few places that were broken.
--root
is set, your dataset was being saved inroot/DATA
instead ofroot/hf_username/repo
.control_robot record
on an existing dataset, you would get an exception because it was trying to path.mkdir(exist_ok=false), when actually, it should beexist_ok=True
.How it was tested
How to checkout & try? (for the reviewer)
Here's how I've been running
control_robot record