-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-compose
support for easier and more portable environment set-up
#519
Open
apockill
wants to merge
22
commits into
huggingface:main
Choose a base branch
from
apockill:feature/docker-compose
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apockill
commented
Nov 23, 2024
@@ -0,0 +1,79 @@ | |||
FROM nvidia/cuda:12.2.2-devel-ubuntu22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this build is identical to docker/lerobot-gpu-dev
, except:
- added the poetry install step and
POETRY_EXTRAS
env variable, using buildkit caching - added poetry as the
ENTRYPOINT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This PR enables users to easily build and enter a docker container which has lerobot and it's dependencies installed.
Installing lerobot is now as easy as:
and that plops you right into a container within a tested lerobot environment.
Features:
Why:
control_robot
record functionality expects that I will want to save my video usinglibsvtav1
(seevideo_utils.encode_video_frames
). However, for whatever reason my version of ffmpeg doesn't allow that, and I had to manually edit code to get off the ground.Which froze my development, since I wanted to run
imshow
and check out the cameras when debugging policies.Anyways, I think it'd be exciting to give users another way to install dependencies.
I don't want to get too far into this without some buy-in. Please let me know if this is interesting, and would be wanted. Cheers!
How it was tested
If folks agree this is desired, I'll add a CI pipeline that validates the build.
Personally, I'm still working on testing this. I'll report back after feedback from reviewers.
Here's what I've personally tested, so far:
How to checkout & try? (for the reviewer)
Just go ahead and check out my fork, and run the commands I documented in the README. I'm most interested in tests done in different hardware. I was thinking of supporting GPU and CPU cases, but is it worth supporting ARM images (a la Jetson) as well?
TODO:
docker run lerobot-gpu
or 'docker run lerobot-cpu'. It might "just work" already on cpu machines, I'll test that later. It would be easier to maintain just one Dockerfile.