Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if setup task is actually still running #874

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Check if setup task is actually still running #874

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e510c86
Check if setup task is actually still running
agners Sep 4, 2024
2d08d06
Use done callback instead
agners Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion matter_server/server/device_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1419,7 +1419,8 @@ async def _setup_node(self, node_id: int) -> None:

def _setup_node_create_task(self, node_id: int) -> asyncio.Task | None:
"""Create a task for setting up a node with retry."""
if node_id in self._setup_node_tasks:
task = self._setup_node_tasks.get(node_id, None)
if task and not task.done():
node_logger = self.get_node_logger(LOGGER, node_id)
node_logger.debug("Setup task exists already for this Node")
return None
Expand Down