Check if setup task is actually still running #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On first setup, we create a task and the task will remain in the task list. If a node gets offline and rediscovered on mDNS again, we will need to setup the node again. In this case we'll have that previous task, but it will be done. So check if the task is done and if so allow starting another setup task.
marcelveldt
approved these changes
Sep 4, 2024
This avoids stale tasks to be stored.
marcelveldt
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first setup, we create a task and the task will remain in the task list. If a node gets offline and rediscovered on mDNS again, we will need to setup the node again. In this case we'll have that previous task, but it will be done. So check if the task is done and if so allow starting another setup task.
Fixes introduced in #873.