Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release tag as project version when creating a release #326

Conversation

agners
Copy link
Collaborator

@agners agners commented Jun 22, 2023

Use the tag created by the GitHub release and write it in the Python project metadata.

This is in preparation for Docker image build, which will rely on the release tag to fetch the latest Matter Server from PyPI.

@marcelveldt
Copy link
Contributor

This has a side-effect that breaks the development environment due to the version check

@frenck
Copy link
Contributor

frenck commented Jun 22, 2023

This has a side-effect that breaks the development environment due to the version check

I'm not fully following that one, is there something special done with version checks somewhere?

@marcelveldt
Copy link
Contributor

Ignore my comment. I removed that version check long time ago (and replaced it by the schema version) - time for coffee :-)

Copy link
Contributor

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

One comment is maybe put a comment in the projectfile that we dynamically generate the version from the github release ?

pyproject.toml Show resolved Hide resolved
@agners agners merged commit 0e61262 into home-assistant-libs:main Jun 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants