Validate GitHub release on publish #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
reviewed
Jun 22, 2023
Comment on lines
+23
to
+29
| - name: Validate tag matches Python project version | ||
| shell: python | ||
| run: |- | ||
| import tomli | ||
| with open("pyproject.toml", "rb") as f: | ||
| pyproject = tomli.load(f) | ||
| assert pyproject["project"]["version"] == "${{ steps.vars.outputs.tag }}" |
There was a problem hiding this comment.
Alternatively (and IMHO better solution), is to not set it and update it on release automatically.
There was a problem hiding this comment.
Hm, so that would involve reading pyproject.toml here, setting the version and writing it back out? Or is there a better way to do this? It seems that Python build doesn't like a pyproject.toml without the version in the project section.
There was a problem hiding this comment.
I've implemented that in a new PR, see #326.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the tag created by the GitHub release matches the Python project metadata.
This is in preparation for Docker image build, which will rely on the release tag to fetch the latest Matter Server from PyPI.