Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFR-3334 Judge Approve Orders - approves or changes #1997

Open
wants to merge 73 commits into
base: DFR-3332-Judge-Approve-Orders---starting-page
Choose a base branch
from
Open

DFR-3334 Judge Approve Orders - approves or changes #1997

wants to merge 73 commits into from

Commits on Nov 21, 2024

  1. DFR-3334 WIP

    Ashley Wong committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    298d71a View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' into DFR… 

    …-3334-Approves-or-Changesv2

# Conflicts:
#	src/main/java/uk/gov/hmcts/reform/finrem/caseorchestration/handler/judgeapproval/ApproveDraftOrdersAboutToStartHandler.java
    Ashley Wong committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2b42d47 View commit details
    Browse the repository at this point in the history

  2. missing imports

    Ashley Wong committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2d97afd View commit details
    Browse the repository at this point in the history

  3. clear judgeApproval fields and hearingInstruction

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    6622d66 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/DFR-3334-Approves-or-Changesv2' … 

    …into DFR-3334-Approves-or-Changesv2
    @hamzahtahirhmcts
    hamzahtahirhmcts committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    a1a4ccf View commit details
    Browse the repository at this point in the history

  5. Add test case.

    Ashley Wong committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    aa48f1a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' into DFR… 

    …-3334-Approves-or-Changesv2
    Ashley Wong committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    11fa699 View commit details
    Browse the repository at this point in the history

  7. Refactoring

    Ashley Wong committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2b2a515 View commit details
    Browse the repository at this point in the history

  8. Refactor mid event test case.

    Ashley Wong committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    61183bc View commit details
    Browse the repository at this point in the history

  9. Extract duplicated codes.

    Ashley Wong committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    071aef2 View commit details
    Browse the repository at this point in the history

  10. Remove unused import

    Ashley Wong committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    71f3f5e View commit details
    Browse the repository at this point in the history

  11. Add JavaDoc

    Ashley Wong committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    79a2020 View commit details
    Browse the repository at this point in the history

  12. Remove a blank line.

    Ashley Wong committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2bbe636 View commit details
    Browse the repository at this point in the history

  13. Extract it to a private method

    Ashley Wong committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f8b2852 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. WIP - populating status (setting to draftOrdersReviewCollection)

    Ashley Wong committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ecdc3ad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' into DFR… 

    …-3334-Approves-or-Changesv2
    Ashley Wong committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7cf3fdc View commit details
    Browse the repository at this point in the history

  3. WIP - populating status (applying status to agreedDraftOrderCollection)

    Ashley Wong committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    e95113a View commit details
    Browse the repository at this point in the history

  4. Replace the existing PSA with the amended document

    Ashley Wong committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    6a3d426 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' into DFR… 

    …-3334-Approves-or-Changesv2

# Conflicts:
#	src/main/java/uk/gov/hmcts/reform/finrem/caseorchestration/model/ccd/draftorders/review/DraftOrderDocumentReview.java
    Ashley Wong committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    4e9ede1 View commit details
    Browse the repository at this point in the history

  2. Remove unused method.

    Ashley Wong committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    dc9e7c7 View commit details
    Browse the repository at this point in the history

  3. Introduced Approvable interface.

    Ashley Wong committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    e4ba475 View commit details
    Browse the repository at this point in the history

  4. Set AgreedDraftOrder to be Approvable.

    Ashley Wong committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    4e90747 View commit details
    Browse the repository at this point in the history

  5. Add test cases for those Approvable objects.

    Ashley Wong committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    316e62d View commit details
    Browse the repository at this point in the history

  6. Setting HearingInstruction

    Ashley Wong committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ca5cef9 View commit details
    Browse the repository at this point in the history

  7. Add test case.

    Ashley Wong committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    509cf5b View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Add unit test

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    dd85472 View commit details
    Browse the repository at this point in the history

  2. Fixing typeOfHearing

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    8b2b9c5 View commit details
    Browse the repository at this point in the history

  3. More test cases.

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    6d8c951 View commit details
    Browse the repository at this point in the history

  4. syntax fix

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    4dad099 View commit details
    Browse the repository at this point in the history

  5. update unit tests

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    b747f28 View commit details
    Browse the repository at this point in the history

  6. increase test coverage.

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    1e93295 View commit details
    Browse the repository at this point in the history

  7. update test

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    d5f96e6 View commit details
    Browse the repository at this point in the history

  8. more test case.

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    9d804ee View commit details
    Browse the repository at this point in the history

  9. revert

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    557b1ed View commit details
    Browse the repository at this point in the history

  10. Revert blank lines change.

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    e500449 View commit details
    Browse the repository at this point in the history

  11. typo

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    061e75c View commit details
    Browse the repository at this point in the history

  12. NPE fix and update test case.

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    0ea85a2 View commit details
    Browse the repository at this point in the history

  13. tidy up

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    ffcc535 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' into DFR… 

    …-3334-Approves-or-Changesv2
    @so99y
    so99y authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    0b17a8d View commit details
    Browse the repository at this point in the history

  15. Test case to cover throwing exception

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    5ec76a6 View commit details
    Browse the repository at this point in the history

  16. update test case

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    5a6360c View commit details
    Browse the repository at this point in the history

  17. use SEPARATOR

    Ashley Wong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    488d334 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2024

  1. increase coverage

    Ashley Wong committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    e33c9d9 View commit details
    Browse the repository at this point in the history

  2. update test case

    Ashley Wong committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    6889ef7 View commit details
    Browse the repository at this point in the history

  3. increase test coverage

    Ashley Wong committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    45e4638 View commit details
    Browse the repository at this point in the history

  4. Renaming

    Ashley Wong committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    44cd277 View commit details
    Browse the repository at this point in the history

  5. Bug fix

    Ashley Wong committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    8c879e7 View commit details
    Browse the repository at this point in the history

  6. checkstyle

    Ashley Wong committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    720835e View commit details
    Browse the repository at this point in the history

  7. Fix test case.

    Ashley Wong committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    072d95e View commit details
    Browse the repository at this point in the history

  8. Update test case

    Ashley Wong committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    8b50076 View commit details
    Browse the repository at this point in the history

  9. tidy up

    Ashley Wong committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    3d578c7 View commit details
    Browse the repository at this point in the history

  10. Remove static

    Ashley Wong committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    ccbec3c View commit details
    Browse the repository at this point in the history

  11. wording fix.

    Ashley Wong committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    5f9cd9e View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' into DFR… 

    …-3334-Approves-or-Changesv2
    Ashley Wong committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    4e9b8fb View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' into DFR… 

    …-3334-Approves-or-Changesv2
    Ashley Wong committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    02a0669 View commit details
    Browse the repository at this point in the history

  2. Separate methods into JudgeApprovalResolver and refactor code

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    751c137 View commit details
    Browse the repository at this point in the history

  3. comment tests

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    2cb8350 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/DFR-3334-Approves-or-Changesv2' … 

    …into DFR-3334-Approves-or-Changesv2
    @hamzahtahirhmcts
    hamzahtahirhmcts committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    735c619 View commit details
    Browse the repository at this point in the history

  5. Move buildWhichOrderDynamicList to MidEventHandler

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    f859bf5 View commit details
    Browse the repository at this point in the history

  6. Remove a blank line.

    Ashley Wong committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    10253ee View commit details
    Browse the repository at this point in the history

  7. checkstyle

    Ashley Wong committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    5583749 View commit details
    Browse the repository at this point in the history

  8. Change approvalDate to LocalDateTime

    Ashley Wong committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    6a03898 View commit details
    Browse the repository at this point in the history

  9. Clear showWarningMessageToJudge

    Ashley Wong committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    279638c View commit details
    Browse the repository at this point in the history

  10. Bug fix

    Ashley Wong committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    e7495fa View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' into DFR… 

    …-3334-Approves-or-Changesv2
    Ashley Wong committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    975eafe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' into DFR… 

    …-3334-Approves-or-Changesv2
    Ashley Wong committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    9ab6898 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' into DFR… 

    …-3334-Approves-or-Changesv2
    Ashley Wong committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    1bb2e8c View commit details
    Browse the repository at this point in the history

  4. fix tests in DraftOrderServiceTest

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    6e720af View commit details
    Browse the repository at this point in the history

  5. checkstyle

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    42ca7e1 View commit details
    Browse the repository at this point in the history

  6. Add @requiredargsconstructor

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    cbee155 View commit details
    Browse the repository at this point in the history

  7. Tests for ApproveOrderService

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    91c53e2 View commit details
    Browse the repository at this point in the history

  8. Move methods into HearingProcessor

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    9dd5c61 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' into DFR… 

    …-3334-Approves-or-Changesv2
    Ashley Wong committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    3bc4444 View commit details
    Browse the repository at this point in the history