DFR-3334 Judge Approve Orders - approves or changes #1997
+1,982
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-3334-Approves-or-Changesv2 # Conflicts: # src/main/java/uk/gov/hmcts/reform/finrem/caseorchestration/handler/judgeapproval/ApproveDraftOrdersAboutToStartHandler.java
…into DFR-3334-Approves-or-Changesv2
…-3334-Approves-or-Changesv2
…-3334-Approves-or-Changesv2
…-3334-Approves-or-Changesv2 # Conflicts: # src/main/java/uk/gov/hmcts/reform/finrem/caseorchestration/model/ccd/draftorders/review/DraftOrderDocumentReview.java
Plan Result (aat) |
Plan Result (prod) |
so99y
changed the base branch from
master
to
DFR-3332-Judge-Approve-Orders---starting-page
jthmcts
reviewed
Dec 2, 2024
There was a problem hiding this comment.
ApproveOrderService has a lot of protected methods but they really seem to be private. So the protected visibility is only there to enable them to be unit tested. This doesn't seem a good approach. If a class is so complex that private methods need to be tested in isolation then that suggests you should refactor your code. It's ok to create small classes. They can be package private if they are only required in judgeapproval.
…-3334-Approves-or-Changesv2
…-3334-Approves-or-Changesv2
…into DFR-3334-Approves-or-Changesv2
…-3334-Approves-or-Changesv2
…-3334-Approves-or-Changesv2
…-3334-Approves-or-Changesv2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
See DFR-3334
Change description
Testing done
Checklist