Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include count in html #887

Merged
merged 4 commits into from
Jun 30, 2023
Merged

include count in html #887

merged 4 commits into from
Jun 30, 2023

Conversation

bendichter
Copy link
Contributor

image

@bendichter bendichter requested a review from oruebel June 30, 2023 15:28
@bendichter bendichter mentioned this pull request Jun 30, 2023
Closed
@oruebel
Copy link
Contributor

oruebel commented Jun 30, 2023

Looks good to me. Can you please update the tests.

@rly
Copy link
Contributor

rly commented Jun 30, 2023

I like this one the best too.

@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (6043e77) 88.17% compared to head (dd3d55f) 88.20%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #887      +/-   ##
==========================================
+ Coverage   88.17%   88.20%   +0.02%     
==========================================
  Files          44       44              
  Lines        9067     9070       +3     
  Branches     2595     2596       +1     
==========================================
+ Hits         7995     8000       +5     
+ Misses        757      756       -1     
+ Partials      315      314       -1
Impacted Files Coverage Δ
src/hdmf/container.py 90.92% <100.00%> (+0.29%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bendichter
Copy link
Contributor Author

FooSingle

containers (2)
obj1
obj2

@bendichter bendichter requested a review from rly June 30, 2023 17:39
@bendichter
Copy link
Contributor Author

@rly @oruebel ok, this is ready to go

@oruebel oruebel merged commit 5269c1f into dev Jun 30, 2023
28 checks passed
@oruebel oruebel deleted the html_include_count branch June 30, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oruebel oruebel oruebel approved these changes

@rly rly Awaiting requested review from rly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bendichter @oruebel @rly