-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve html output #886
improve html output #886
Conversation
Vote for Option 1 |
Vote for Option 2 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #886 +/- ##
==========================================
- Coverage 88.17% 88.15% -0.02%
==========================================
Files 44 44
Lines 9067 9069 +2
Branches 2595 2596 +1
==========================================
Hits 7995 7995
- Misses 757 758 +1
- Partials 315 316 +1
☔ View full report in Codecov by Sentry. |
I don't personally mind the way it is because those exist, but are just empty. I guess there's the expectation that if something has the triangle that the expansion leads to an output. But hard for me to tell if that would freak people out or they would just understand that it could be expanded were there something there. So Option 1 (or how it is) is fine, but I would not advocate for Option 2 (unless there's the situation in which there are a lot of these) because it lets the user know that something could be there but isn't. |
Option 3: #887 (could be combined with 1 or 2) |
Option 3 is the best I think. |
Closed in favor of #887 |
@edeno
current:
Summary expandable is rendered for fields that are empty. See the expanded groups at the bottom that are empty:
option 1: render them as empty
option 2: don't render them
I have a slight preference for option 2, but I think option 1 would be fine and would be an improvement.