Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve html output #886

Closed
wants to merge 2 commits into from
Closed

improve html output #886

wants to merge 2 commits into from

Conversation

bendichter
Copy link
Contributor

@edeno

current:

Summary expandable is rendered for fields that are empty. See the expanded groups at the bottom that are empty:

image

option 1: render them as empty

image

option 2: don't render them

image

I have a slight preference for option 2, but I think option 1 would be fine and would be an improvement.

@bendichter bendichter requested review from rly and oruebel June 30, 2023 14:44
@bendichter
Copy link
Contributor Author

Vote for Option 1

@bendichter
Copy link
Contributor Author

Vote for Option 2

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (6043e77) 88.17% compared to head (972b15a) 88.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #886      +/-   ##
==========================================
- Coverage   88.17%   88.15%   -0.02%     
==========================================
  Files          44       44              
  Lines        9067     9069       +2     
  Branches     2595     2596       +1     
==========================================
  Hits         7995     7995              
- Misses        757      758       +1     
- Partials      315      316       +1     
Impacted Files Coverage Δ
src/hdmf/container.py 90.39% <0.00%> (-0.24%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@edeno
Copy link
Contributor

edeno commented Jun 30, 2023

I don't personally mind the way it is because those exist, but are just empty. I guess there's the expectation that if something has the triangle that the expansion leads to an output. But hard for me to tell if that would freak people out or they would just understand that it could be expanded were there something there.

So Option 1 (or how it is) is fine, but I would not advocate for Option 2 (unless there's the situation in which there are a lot of these) because it lets the user know that something could be there but isn't.

@bendichter
Copy link
Contributor Author

bendichter commented Jun 30, 2023

Option 3: #887 (could be combined with 1 or 2)

@edeno
Copy link
Contributor

edeno commented Jun 30, 2023

Option 3 is the best I think.

@rly
Copy link
Contributor

rly commented Jun 30, 2023

Closed in favor of #887

@rly rly closed this Jun 30, 2023
@rly rly deleted the improve_repr_html branch June 30, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants