Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to run check-sdist on the right ghcs #10448

Merged
merged 1 commit into from
Oct 26, 2024
Merged

try to run check-sdist on the right ghcs #10448

merged 1 commit into from
Oct 26, 2024

Conversation

geekosaur
Copy link
Collaborator

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur geekosaur force-pushed the sdists-wrong-vers branch 4 times, most recently from 47c2be2 to 1da8850 Compare October 11, 2024 23:58
@geekosaur
Copy link
Collaborator Author

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 12, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@geekosaur
Copy link
Collaborator Author

FWIW, I pushed an intermediate version that ran even on master and verified that it now runs for each version instead of only the oldest / last in the matrix array.

@Kleidukos Kleidukos added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Oct 24, 2024
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Oct 24, 2024
@mergify mergify bot merged commit 9c499b1 into haskell:master Oct 26, 2024
48 checks passed
@mergify mergify bot mentioned this pull request Oct 26, 2024
Merged
2 tasks
geekosaur added a commit to geekosaur/cabal that referenced this pull request Oct 26, 2024
@geekosaur
final fixups to sdist check
4ab022b 
validated on 3.12 branch and applied in backport of haskell#10448; this
brings the fixes up to `master`
@geekosaur geekosaur mentioned this pull request Oct 26, 2024
Merged
2 tasks
geekosaur added a commit to geekosaur/cabal that referenced this pull request Oct 26, 2024
@geekosaur
final fixups to sdist check
e2c1861 
validated on 3.12 branch and applied in backport of haskell#10448; this
brings the fixes up to `master`
geekosaur added a commit to geekosaur/cabal that referenced this pull request Oct 26, 2024
@geekosaur
final fixups to sdist check
6555721 
validated on 3.12 branch and applied in backport of haskell#10448; this
brings the fixes up to `master`
geekosaur added a commit to geekosaur/cabal that referenced this pull request Oct 26, 2024
@geekosaur
final fixups to sdist check
3805ba4 
validated on 3.12 branch and applied in backport of haskell#10448; this
brings the fixes up to `master`
mergify bot added a commit that referenced this pull request Oct 26, 2024
@mergify
Merge pull request #10477 from haskell/mergify/bp/3.12/pr-10448
61d6947 
Backport #10448: try to run check-sdist on the right ghcs
geekosaur added a commit to geekosaur/cabal that referenced this pull request Oct 26, 2024
@geekosaur
final fixups to sdist check
1870676 
validated on 3.12 branch and applied in backport of haskell#10448; this
brings the fixes up to `master`
@geekosaur
Copy link
Collaborator Author

@mergify backport 3.14

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 26, 2024 •
edited
Loading

backport 3.14

✅ Backports have been created

@mergify mergify bot mentioned this pull request Oct 26, 2024
Merged
2 tasks
Mikolaj pushed a commit to geekosaur/cabal that referenced this pull request Dec 18, 2024
@geekosaur @Mikolaj
final fixups to sdist check
8e076b6 
validated on 3.12 branch and applied in backport of haskell#10448; this
brings the fixes up to `master`
mergify bot pushed a commit that referenced this pull request Dec 18, 2024
@geekosaur @mergify
final fixups to sdist check
cf6717d 
validated on 3.12 branch and applied in backport of #10448; this
brings the fixes up to `master`

(cherry picked from commit 8e076b6)
@mergify mergify bot mentioned this pull request Dec 18, 2024
Open
2 tasks
mergify bot added a commit that referenced this pull request Dec 19, 2024
@mergify
Merge pull request #10480 from haskell/mergify/bp/3.14/pr-10448
692a80b 
Backport #10448: try to run check-sdist on the right ghcs
Mikolaj pushed a commit that referenced this pull request Dec 19, 2024
@geekosaur @Mikolaj
final fixups to sdist check
eb4dcb7 
validated on 3.12 branch and applied in backport of #10448; this
brings the fixes up to `master`

(cherry picked from commit 8e076b6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kleidukos Kleidukos Kleidukos approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

Assignees
No one assigned
Labels
continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geekosaur @ulysses4ever @Kleidukos