final fixups to sdist check #10478
Open
final fixups to sdist check #10478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
force-pushed
the
check-sdist-3
branch
2 times, most recently
from
e2c1861
to
6555721
Compare
ulysses4ever
approved these changes
Oct 26, 2024
|
It led to the first actual success of the check on 3.12 branch where it originated (as a fixup to #10477), so I'm fairly confident that it's now working properly. |
geekosaur
force-pushed
the
check-sdist-3
branch
from
6555721
to
3805ba4
Compare
validated on 3.12 branch and applied in backport of haskell#10448; this brings the fixes up to `master`
geekosaur
force-pushed
the
check-sdist-3
branch
from
3805ba4
to
1870676
Compare
|
Not needed for 3.14 release, but we probably want it in the tree before we make any later 3.14 releases so we can verify that they don't break compatibility with the bundled Cabal in 9.12.1. Note that the backport will need |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validated on 3.12 branch and applied in backport of #10448; this brings the fixes up to
masterTemplate B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR:
Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).actually taken from a backport!