-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move writing of stored keys to the end of Vault initialization. #28538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorr
added
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
backport/ent/1.17.x+ent
Changes are backported to 1.17.x+ent
labels
Sep 30, 2024
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Sep 30, 2024
CI Results: |
Build Results: |
victorr
added
backport/1.17.x
and removed
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
backport/ent/1.17.x+ent
Changes are backported to 1.17.x+ent
labels
Oct 1, 2024
victorr
force-pushed
the
victorr/vault-31173-stored-keys-at-init-end
branch
from
October 1, 2024 14:02
fc20ae5
to
90cbb1e
Compare
Move the call to SetStoredKeys to the end of the initialization process. On Vault Enterprise, this minimizes the chances that the initial seal re-wrap fails when a node other than the one performing initialization becomes the active one.
victorr
force-pushed
the
victorr/vault-31173-stored-keys-at-init-end
branch
from
October 1, 2024 17:04
90cbb1e
to
bc31ec7
Compare
I verified that these changes cause no problems in ENT. |
kitography
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty clean - I'm not seeing anything here which would make a mess of anything.
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.18.x
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
pr/no-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the call to SetStoredKeys to the end of the initialization process. On Vault Enterprise, this minimizes the chances that the initial seal re-wrap fails when a node other than the one performing initialization becomes the active one.
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+ent
labels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.x
label, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.