Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Move writing of stored keys to the end of Vault initialization. into release/1.18.x #28555

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #28538 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

The below text is copied from the body of the original PR.


Description

Move the call to SetStoredKeys to the end of the initialization process. On Vault Enterprise, this minimizes the chances that the initial seal re-wrap fails when a node other than the one performing initialization becomes the active one.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 1, 2024
@victorr victorr added this to the 1.18.0 milestone Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

CI Results:
All Go tests succeeded! ✅

@victorr victorr enabled auto-merge (squash) October 1, 2024 18:47
Copy link

github-actions bot commented Oct 1, 2024

Build Results:
All builds succeeded! ✅

@victorr victorr merged commit dcbc4f3 into release/1.18.x Oct 1, 2024
76 of 77 checks passed
@victorr victorr deleted the backport/victorr/vault-31173-stored-keys-at-init-end/recently-famous-tortoise branch October 1, 2024 18:54
victorr added a commit that referenced this pull request Oct 2, 2024
victorr added a commit that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants