UI: Move OIDC key header out of form component #27848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
commented
Jul 23, 2024
| @@ -49,7 +49,6 @@ module('Integration | Component | oidc/key-form', function (hooks) { | |||
| /> | |||
| `); | |||
|
|
|||
| assert.dom('[data-test-oidc-key-title]').hasText('Create Key', 'Form title renders correct text'); | |||
There was a problem hiding this comment.
I deleted these assertions instead of move them because they no longer rely on @model.isNew logic and are hardcoded
|
CI Results: |
Monkeychip
approved these changes
Jul 23, 2024
|
Build Results: |
hellobontempo
commented
Jul 23, 2024
| <PageHeader as |p|> | ||
| <p.top> | ||
| <Hds::Breadcrumb> | ||
| <Hds::Breadcrumb::Item @text="Keys" @route="vault.cluster.access.oidc.keys" /> |
1 task
Monkeychip
pushed a commit
that referenced
this pull request
Jul 24, 2024
* move pageheader to route template * remove title assertions because no longer reliant on isNew logic * change @model to this.model * remove test selectors * add keys base breadcrumb * update assertion count
Monkeychip
pushed a commit
that referenced
this pull request
Jul 24, 2024
* move pageheader to route template * remove title assertions because no longer reliant on isNew logic * change @model to this.model * remove test selectors * add keys base breadcrumb * update assertion count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the form page header to the route component, this supports the WIF work so that the form can be rendered in a search select modal. There are no user facing changes
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabelsinstead of the old style
backport/x.x.xlabels.the normal
backport/x.x.xlabel (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.