WIF AWS: add create functionality to SearchSelectWithModal for identity_token_key #27794

Monkeychip · 2024-07-16T17:08:52Z

Description

This PR adds the modal/create part to the aws secret engine mount.

enterprise test pass.

if a user has read access it identity/oidc/key they can either search existing oidc/keys or they can create one.
if a user does not have read access they can type a key into an input box. If the key does not exist then the API will surface an error.
FYI: We are surfacing about half the fields used to create an identity/oidc/key (at the very bottom I'll provide a screenshot of that full form). Design would like to only include a limited / required set of form fields to create an identity_token_key here. This has been cleared with the backend as well.
It's important that a user is given the ability to add a key at the mounting stage of an engine because they cannot add this later via the UI.

Screenshots

Admin user with full access to `identity/oidc/key`

If they created a key
(I have a nice to have ticket to fix the styling of the flash message. That was an existing issue and trying to keep scope tight)

Admin user without access to `identity/oidc/key`

If they enter a key that does not exist, the API will surface the following error:

The full form to create an `identity/oidc/key` found via the OIDC provider workflow.

* test coverage for bug * Add defaultValue to acmeAccountSafetyBuffer * fix failing PKI tests * Add changelog

* Update CHANGELOG.md for 1.17.2 1.16.6 and 1.15.12 * Update CHANGELOG.md Co-authored-by: Meggie <[email protected]> --------- Co-authored-by: Meggie <[email protected]>

…27757) * Add custom tags section to sync overview, specifically call out normalizing names and tags * Update website/content/docs/sync/index.mdx Co-authored-by: Theron Voran <[email protected]> * Fix typo --------- Co-authored-by: Theron Voran <[email protected]>

…ed (#27760)

* add a retry-command script * add license header to retry script

* Update go.mod and sdk/go.mod to Go 1.22 * manually bump the import and re-go-mod-tidy

…er (#27767) * Docs: PGP & gpg version requirements with ECDH & Vault 1.13.x or higher. * Update website/content/docs/concepts/pgp-gpg-keybase.mdx Co-authored-by: Sarah Chavis <[email protected]> --------- Co-authored-by: Sarah Chavis <[email protected]>

…ts (#27646) * Docs: autosnapshots notes around AWS EKS & S3 configuration requirments. * Docs: corrected autosnapshots notes around AWS EKS & S3 configuration requirments. * Update website/content/docs/enterprise/automated-integrated-storage-snapshots.mdx Co-authored-by: Sarah Chavis <[email protected]> * Update website/content/api-docs/system/storage/raftautosnapshots.mdx Co-authored-by: Sarah Chavis <[email protected]> --------- Co-authored-by: Sarah Chavis <[email protected]>

* Add map between model types and helpUrls, update tests * replace modelProto.getHelpUrl with new helper util * Remove all useOpenApi and getHelpUrl instances from models * Add missing auth config model type

… (GHA) (#27781)

* move some auth controller logic to route page component * remove unused vars * fix action handling so this context is retained * rename authpage to auth-form-page * rename auth-route-page to auth-splash-page * link jira VAULT-28251 * wowww typo * add padding to mfa form alert message * update component name in tests * alphabetize args * use auth helpers for login method * remove async, await * rename components * update jsdoc * add comment

…GitHub Actions (GHA) (#27786)

github-actions · 2024-07-16T17:18:58Z

CI Results:
All Go tests succeeded! ✅

* Update docs around dead_server_last_contact_threshold * Grammar

* yield all overview card actions * yield remaining overview card content to the correct block * close overview card in test * fix typo * fix route typo, add selectors where needed * fix class typo add one more selector

* Create date-range component with tests * update selectors and callback behavior * update cc tests & selectors * cleanup * RIP calendar-widget and date-dropdown -- you were good components * reset on close * Add changelog * use parseApiTimestamp * fix test * cleanup * make date-range typescript, update behavior * add words * minor styling * fix test

github-actions · 2024-07-17T17:17:02Z

Build Results:
All builds succeeded! ✅

ui/app/components/modal-form/oidc-key-template.hbs

* db: refactor postgres test helpers * fix references to refactored test helper * fix references to refactored test helper * fix failing test

* Policy priority NS example * Update website/content/docs/concepts/policies.mdx Modification after review Co-authored-by: Yoko Hyakuna <[email protected]> --------- Co-authored-by: Yoko Hyakuna <[email protected]>

* title case all static breadcrumb labels * test fixes * add missing model

Co-authored-by: Yoko Hyakuna <[email protected]>

* Add a warning about namespace info for HVD * Minor edit

…espace (#27790) * start implementation and testing * changelog * switch changelog description to change

--------- Co-authored-by: Theron Voran <[email protected]>

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.64.0 to 1.64.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.64.0...v1.64.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Violet Hynes <[email protected]>

This PR introduces a no-op CensusManager in CE in an effort to simplify overall maintenance. Resolves: VAULT-27562 Enterprise PR: hashicorp/vault-enterprise#6231

* VAULT-27384 Fix faulty assignments and unchecked errors * Another missed error * Small refactor

* fresh yarn lock * upgrade hds to 4.6.0

… increasing wait on failure (up to 5 seconds and 5 retries) (#27842) Co-authored-by: VAL <[email protected]>

* OSS Changes * Added changelog * Fix build errors

@model

* move pageheader to route template * remove title assertions because no longer reliant on isNew logic * change @model to this.model * remove test selectors * add keys base breadcrumb * update assertion count

…ds in CI to avoid errors when retrying (#27852)

* VAULT-27563 CE changes * Missed push

…7846) * VAULT-28577: change CSV MIME type to text/csv * VAULT-28578: require sudo for export API * add validation and associated error handling * change export API default to 204 if no data returned * VAULT-28579: allow export API in non-root namespace, add filtering support * update test fixtures to reflect filtering changes * TestActivityLog_Export moved to ENT-only test * add test to verify sudo access * add changelog entry

hashishaw and others added 15 commits July 10, 2024 13:50

UI: Fix ACME Account Safety Buffer not able to be turned off (#27742)

b0ee637

* test coverage for bug * Add defaultValue to acmeAccountSafetyBuffer * fix failing PKI tests * Add changelog

Update CHANGELOG.md for 1.17.2 1.16.6 and 1.15.12 (#27753)

f102434

* Update CHANGELOG.md for 1.17.2 1.16.6 and 1.15.12 * Update CHANGELOG.md Co-authored-by: Meggie <[email protected]> --------- Co-authored-by: Meggie <[email protected]>

PKI: Refactor common role path policy code into common area (#27759)

2d7a3fb

don't regenerate mirage data if the date range has already been queri…

979cf90

…ed (#27760)

add a retry-command script (#27754)

56b3208

* add a retry-command script * add license header to retry script

Update go.mod and sdk/go.mod to Go 1.22 (#27771)

815a075

* Update go.mod and sdk/go.mod to Go 1.22 * manually bump the import and re-go-mod-tidy

UI: Move useOpenApi and getHelpUrl methods to util (#27764)

d211602

* Add map between model types and helpUrls, update tests * replace modelProto.getHelpUrl with new helper util * Remove all useOpenApi and getHelpUrl instances from models * Add missing auth config model type

[VAULT-28666] Retry staticcheck download on failure in GitHub Actions…

d9cd3a0

… (GHA) (#27781)

[VAULT-28666] Retry tool download from GitHub releases on failure in …

b7d9008

…GitHub Actions (GHA) (#27786)

remove redundant call to set token in tests (#27723)

bf569c3

modal implementation

3d827a9

Monkeychip added this to the 1.18.0-rc milestone Jul 16, 2024

github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 16, 2024

Monkeychip added ui and removed hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Jul 16, 2024

VioletHynes and others added 5 commits July 16, 2024 14:44

Update docs around dead_server_last_contact_threshold (#27793)

ce90410

* Update docs around dead_server_last_contact_threshold * Grammar

UI: update overview card action handling (#27785)

e88b6b1

* yield all overview card actions * yield remaining overview card content to the correct block * close overview card in test * fix typo * fix route typo, add selectors where needed * fix class typo add one more selector

docs: add missing rotation_statements to mssql api docs (#27800)

d444a32

test coverage

a844800

github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 17, 2024

Monkeychip marked this pull request as ready for review July 17, 2024 17:13

Monkeychip requested a review from a team as a code owner July 17, 2024 17:13

Monkeychip commented Jul 17, 2024

View reviewed changes

ui/app/components/modal-form/oidc-key-template.hbs Outdated Show resolved Hide resolved

fairclothjm and others added 21 commits July 24, 2024 09:09

db: refactor postgres test helpers (#27811)

a4ae97c

* db: refactor postgres test helpers * fix references to refactored test helper * fix references to refactored test helper * fix failing test

Docs: Add a Priority matching policy example using Namespaces (#27792)

60d802c

* Policy priority NS example * Update website/content/docs/concepts/policies.mdx Modification after review Co-authored-by: Yoko Hyakuna <[email protected]> --------- Co-authored-by: Yoko Hyakuna <[email protected]>

Title case all static breadcrumbs (#27808)

499e806

* title case all static breadcrumb labels * test fixes * add missing model

Fixing typo "auth_auth" should be "auto_auth" (#27758)

f8ce9d7

Co-authored-by: Yoko Hyakuna <[email protected]>

[Docs] Add a warning about namespace info for HVD (#27812)

a664fc5

* Add a warning about namespace info for HVD * Minor edit

Docs update for vault helm v0.28.1 release (#27766)

3933323

VAULT-28329: Fix months activity log counts when querying for a nam…

81e9e25

…espace (#27790) * start implementation and testing * changelog * switch changelog description to change

docs/vso: instant updates (#27668)

b404411

Update VSO docs for auto CRD upgrade behaviour (#27763)

92917a2

VSO: update docs for VaultAuthGlobals (#27797)

54b75bd

--------- Co-authored-by: Theron Voran <[email protected]>

CE no-op CensusManager (#27827)

e28feae

This PR introduces a no-op CensusManager in CE in an effort to simplify overall maintenance. Resolves: VAULT-27562 Enterprise PR: hashicorp/vault-enterprise#6231

VAULT-27384 Fix faulty assignments and unchecked errors (#27810)

572ccb6

* VAULT-27384 Fix faulty assignments and unchecked errors * Another missed error * Small refactor

Bump VSO versions to 0.8.0 (#27835)

c316ce7

UI: upgrade HDS to 4.6.0 (#27843)

d43cb60

* fresh yarn lock * upgrade hds to 4.6.0

[VAULT-28666] Remove the errexit option from the retry script and add…

0e48c0b

… increasing wait on failure (up to 5 seconds and 5 retries) (#27842) Co-authored-by: VAL <[email protected]>

Deprecate distinct_entities and nont_entity_tokens (#27830)

aed577e

* OSS Changes * Added changelog * Fix build errors

UI: Move OIDC key header out of form component (#27848)

fc20264

* move pageheader to route template * remove title assertions because no longer reliant on isNew logic * change @model to this.model * remove test selectors * add keys base breadcrumb * update assertion count

[VAULT-28666] Enable the --clobber flag on GitHub CLI release downloa…

5dbd1d1

…ds in CI to avoid errors when retrying (#27852)

VAULT-27563 CE changes (#27847)

a5a578e

* VAULT-27563 CE changes * Missed push

Monkeychip requested review from a team as code owners July 24, 2024 15:09

Merge branch 'main' into ui/VAULT-28459/add-modal

1aae5d7

Monkeychip deleted the branch ui/VAULT-27326/wif-aws-sidebranch July 24, 2024 15:33

Monkeychip closed this Jul 24, 2024

Monkeychip deleted the ui/VAULT-28459/add-modal branch July 24, 2024 15:34

Monkeychip restored the ui/VAULT-28459/add-modal branch July 24, 2024 15:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIF AWS: add create functionality to SearchSelectWithModal for identity_token_key #27794

WIF AWS: add create functionality to SearchSelectWithModal for identity_token_key #27794

Monkeychip commented Jul 16, 2024 •

edited

Loading

github-actions bot commented Jul 16, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

WIF AWS: add create functionality to SearchSelectWithModal for identity_token_key #27794

WIF AWS: add create functionality to SearchSelectWithModal for identity_token_key #27794

Conversation

Monkeychip commented Jul 16, 2024 • edited Loading

Description

Screenshots

Admin user with full access to identity/oidc/key

Admin user without access to identity/oidc/key

The full form to create an identity/oidc/key found via the OIDC provider workflow.

github-actions bot commented Jul 16, 2024 • edited Loading

github-actions bot commented Jul 17, 2024 • edited Loading

Monkeychip commented Jul 16, 2024 •

edited

Loading

Admin user with full access to `identity/oidc/key`

Admin user without access to `identity/oidc/key`

The full form to create an `identity/oidc/key` found via the OIDC provider workflow.

github-actions bot commented Jul 16, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading