Allow degenerate triangles #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method doesn't make sense yet, as `Triangle::new` explicitly forbids degenerate triangles. This is about to change though, and adding this method is preparation for that.
This check is currently redundant with what the `Triangle` constructor already does. The constructor will soon get simplified though, and then the new check will be necessary.
Degenerate triangles are actually useful in some cases, and I'm actually working on some code that needs them. Thus, the constructor as it was, was too restrictive.
With the constructor no longer preventing degenerate triangle, there's no reason to keep it private.
With the `points` field public, it has become redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring triangles to be valid on construction is too restrictive. In fact, I'm working on some code (for #2118) that would benefit from degenerate triangles being possible to represent.