-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow degenerate triangles #2434
Merged
Merged
Commits on Jul 29, 2024
-
The method doesn't make sense yet, as `Triangle::new` explicitly forbids degenerate triangles. This is about to change though, and adding this method is preparation for that.
Configuration menu - View commit details
-
Copy full SHA for d9533ee - Browse repository at this point
Copy the full SHA d9533eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3529eca - Browse repository at this point
Copy the full SHA 3529ecaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4b880d - Browse repository at this point
Copy the full SHA d4b880dView commit details -
Make sure triangulation returns valid triangles
This check is currently redundant with what the `Triangle` constructor already does. The constructor will soon get simplified though, and then the new check will be necessary.
Configuration menu - View commit details
-
Copy full SHA for 0df27de - Browse repository at this point
Copy the full SHA 0df27deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 227b2ad - Browse repository at this point
Copy the full SHA 227b2adView commit details
Commits on Jul 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f5668b0 - Browse repository at this point
Copy the full SHA f5668b0View commit details -
Allow degenerate triangles to be constructed
Degenerate triangles are actually useful in some cases, and I'm actually working on some code that needs them. Thus, the constructor as it was, was too restrictive.
Configuration menu - View commit details
-
Copy full SHA for cc15b15 - Browse repository at this point
Copy the full SHA cc15b15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63a4546 - Browse repository at this point
Copy the full SHA 63a4546View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d149d2 - Browse repository at this point
Copy the full SHA 1d149d2View commit details -
With the constructor no longer preventing degenerate triangle, there's no reason to keep it private.
Configuration menu - View commit details
-
Copy full SHA for be31c2d - Browse repository at this point
Copy the full SHA be31c2dView commit details -
With the `points` field public, it has become redundant.
Configuration menu - View commit details
-
Copy full SHA for 14e1982 - Browse repository at this point
Copy the full SHA 14e1982View commit details -
Configuration menu - View commit details
-
Copy full SHA for b553b1e - Browse repository at this point
Copy the full SHA b553b1eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.