Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow degenerate triangles #2434

Merged
merged 12 commits into from
Jul 30, 2024
Merged

Allow degenerate triangles #2434

merged 12 commits into from
Jul 30, 2024

Commits on Jul 29, 2024

  1. Add Triangle::is_valid

    The method doesn't make sense yet, as `Triangle::new` explicitly forbids
    degenerate triangles. This is about to change though, and adding this
    method is preparation for that.
    hannobraun committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d9533ee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3529eca View commit details
    Browse the repository at this point in the history
  3. Inline redundant variable

    hannobraun committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d4b880d View commit details
    Browse the repository at this point in the history
  4. Make sure triangulation returns valid triangles

    This check is currently redundant with what the `Triangle` constructor
    already does. The constructor will soon get simplified though, and then
    the new check will be necessary.
    hannobraun committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    0df27de View commit details
    Browse the repository at this point in the history
  5. Make tests more explicit

    hannobraun committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    227b2ad View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Configuration menu
    Copy the full SHA
    f5668b0 View commit details
    Browse the repository at this point in the history
  2. Allow degenerate triangles to be constructed

    Degenerate triangles are actually useful in some cases, and I'm actually
    working on some code that needs them. Thus, the constructor as it was,
    was too restrictive.
    hannobraun committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    cc15b15 View commit details
    Browse the repository at this point in the history
  3. Simplify return value

    hannobraun committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    63a4546 View commit details
    Browse the repository at this point in the history
  4. Update doc comment

    hannobraun committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1d149d2 View commit details
    Browse the repository at this point in the history
  5. Make field of Triangle public

    With the constructor no longer preventing degenerate triangle, there's
    no reason to keep it private.
    hannobraun committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    be31c2d View commit details
    Browse the repository at this point in the history
  6. Remove Triangle::points

    With the `points` field public, it has become redundant.
    hannobraun committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    14e1982 View commit details
    Browse the repository at this point in the history
  7. Remove unused code

    hannobraun committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b553b1e View commit details
    Browse the repository at this point in the history